mapartcraft icon indicating copy to clipboard operation
mapartcraft copied to clipboard

Inaccuracies with water color on map art.

Open DeathTr00per opened this issue 11 months ago • 1 comments

I noticed a previous issue regarding the problem of water color on map art https://github.com/rebane2001/mapartcraft/issues/255, and I've noticed that although it was mentioned that changes were implemented, the schematic output result still accounts for water color incorrectly. I spent some time testing on my map art world to confirm that this is the case, and I'm certain that water's color on maps doesn't rely on the elevation on the block north of it at all when determining color, unlike all other blocks. Instead, it relies on the depth of water to the nearest non-water block. The way the map art generator currently works is that it treats water like any other block, relying on the block north of it to provide its shading. My suggestion to fix the correction of water blocks on map art is to instead generate columns of water to account for whatever shade is required, with the generic scaffolding block placed at the bottom to ensure no inaccuracies (I know myself and many other people chose to build map art over the ocean, so this scaffold block would be required to ensure the color is correct regardless of where the map art is placed). I have some demonstration screenshots here: https://imgur.com/a/bVTZWz0. In this instance, I used waterlogged azalea leaves instead of water, as it produces the same color while also being much easier to manage both in creative and survival mode (why isn't waterlogged leaves a default option in the generator?). The water depths required to generate each shade with the minimum possible materials are as follows: 1 - bright 5 - regular 10 - dark Anyways, I hope some change is able to come of this, as fixing this not only provides access to another hue within a range which minecraft maps are greatly lacking in, but also saves me a lot of work of having to modify a schematic manually which I already generated from the website to get accurate colors.

DeathTr00per avatar Jan 19 '25 20:01 DeathTr00per

I think full water support would be cool although its a little impractical. A more practical middle ground would be in the water color selection you can select for the algorithm to only consider either ocean blue or waterlogged leaves/grates

crubleigh avatar Apr 20 '25 06:04 crubleigh