reagraph icon indicating copy to clipboard operation
reagraph copied to clipboard

Published 20 hours ago • verified publisher icon reaviz

Unpin three

Open dmurvihill opened this issue 1 year ago • 3 comments

#280

dmurvihill avatar Oct 01 '24 06:10 dmurvihill

Deploy Preview for reagraph ready!

Name Link
Latest commit 83783ad4db6f746692fbab6774ff667963991862
Latest deploy log https://app.netlify.com/sites/reagraph/deploys/66fb9bb6e32a280008cf3266
Deploy Preview https://deploy-preview-281--reagraph.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 01 '24 06:10 netlify[bot]

This looks fine to me but I'm weary of this change. We've had issues in the past with three and its depedencies between point versions. What version are you shooting to be on so I can test that.

amcdnl avatar Oct 01 '24 12:10 amcdnl

Yes, that's definitely an issue in three; mrdoob has unfortunately decided to push compatibility management downstream. Pinning a mid-stream library to a specific version of three only makes things worse.

I don't see any good solution other than:

  • Pin each release of reagraph to a min and max version of three
  • Examine the migration guide to verify support for new versions of three as they come out
  • Automate tests against latest three and against their development branch
  • Bump reagraph's major when dropping support for old versions of three

I'm on 161.

dmurvihill avatar Oct 01 '24 18:10 dmurvihill

Closing due to inactivity. Will address this in next release.

amcdnl avatar Jan 13 '25 10:01 amcdnl