reasonml.github.io icon indicating copy to clipboard operation
reasonml.github.io copied to clipboard

Missing files for setupSomeArtifacts.js?

Open jpolitz opened this issue 7 years ago • 0 comments

This is a super-cool project, thanks for having instructions for setting up the bucklescript bundle, it's super-helpful.

I tried following the "hardcore" build instructions and got stuck pretty quickly when trying to run setupSomeArtifacts.js. I know I'm supposed to see an error, but I don't think it's the error I'm expected to see and recover from. Happy to hear if I'm missing something obvious.

On a clean checkout, I run:

cd website
yarn
yarn prepare

which succeed, then I run

$ node setupSomeArtifacts.js
1. Copying refmt.js
2. Copying jsoo_reactjs_jsx_ppx_v2.js
fs.js:1919
  binding.copyFile(src, dest, flags);
          ^

Error: ENOENT: no such file or directory, copyfile '/Users/joe/src/reasonml.github.io/website/playground/bs/jsoo_reactjs_jsx_ppx_v2.js' -> '/Users/joe/src/reasonml.github.io/website/static/js/jsoo_reactjs_jsx_ppx_v2.js'
    at Object.fs.copyFileSync (fs.js:1919:11)
    at Object.<anonymous> (/Users/joe/src/reasonml.github.io/website/setupSomeArtifacts.js:26:4)
    at Module._compile (module.js:624:30)
    at Object.Module._extensions..js (module.js:635:10)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
    at Function.Module.runMain (module.js:665:10)
    at startup (bootstrap_node.js:201:16)
    at bootstrap_node.js:626:3

In setupSomeArtifacts (https://github.com/reasonml/reasonml.github.io/blob/28dd1a2a2a09837e11d9b8ce38483744b1c715a6/website/setupSomeArtifacts.js#L24), it tries to copy website/playground/bs/jsoo_reactjs_jsx_ppx_v2.js, but this file was deleted in this commit: https://github.com/reasonml/reasonml.github.io/commit/74604cfbebf2c11f81f4b23f84bfc89bf8d564de

It seems like maybe that was moved to be in static/ directly? If I comment things out to push past that, I see similar issues where there is no file named exports.js either:

https://github.com/reasonml/reasonml.github.io/blob/28dd1a2a2a09837e11d9b8ce38483744b1c715a6/website/setupSomeArtifacts.js#L191

That I can't find anywhere in the repo, so I'm confused. I feel like I may be missing a step that gets these to files into bs/ somehow, but I'm not sure what it is.

Thanks!

jpolitz avatar May 10 '18 22:05 jpolitz