reason icon indicating copy to clipboard operation
reason copied to clipboard

Build instructions for (inexperienced) contributors

Open hoichi opened this issue 6 years ago • 4 comments

Do you think maybe we need some Getting started instructions for potential contributors with little experience in opam, Dune, Azure, etc.

Personally, I’m looking at the repo and I have some questions like:

  • do you build via make or via Azure CI
  • are there steps you need to run before you run make?
  • how do you start with Azure? Create your personal account and upload the repo?

Of course, maybe any build-related contributions simply needs more experienced contributors. Maybe babysitting inexperienced devs is simply not worth it. What do you think?

hoichi avatar Dec 04 '19 11:12 hoichi

git clone npm install -g esy esy

thangngoc89 avatar Dec 05 '19 14:12 thangngoc89

Thanks a lot!

But should this information be more accessible? Then again, it’s available in src/README.md, so maybe I just didn’t look well enough.

hoichi avatar Dec 06 '19 12:12 hoichi

Yeah, I think that our current README is weird because it includes the information that the fewest number of people would find relevant. It discusses the API version of Reason (calling it as an API) which very few people actually ever need to use.

Let's use this as an opportunity to rethink the most important things that belong on the README.

  1. Link to "how to develop doc" - as well as a brief summary (@thangngoc89's instructions).
  2. Information on how to consume it.

jordwalke avatar Dec 08 '19 07:12 jordwalke

Information on how to consume it.

Exactly. I have to admit that even after running esy I still have a hard time figuring out:

  1. What have I just built? And how do I consume it? (E.g., I presume that the script builds reason & rtop, but how do I use what I’ve built? Should I alter my path so as not to point to rtop installed by bs-platform?
  2. Where are those docs?

Again, I don’t know how ignorant you want your contributors, but if you want some noob feedback, there you are :)

hoichi avatar Dec 09 '19 12:12 hoichi