reason-native icon indicating copy to clipboard operation
reason-native copied to clipboard

Feedback for Rely

Open kyldvs opened this issue 5 years ago • 7 comments

From @Jaredly: https://github.com/jaredly/reason-language-server/blob/rely/test/RunTests.re#L11-L17

// Things I wish rely would do:
// - watch mode would be awesome
// - allow you to select a subset of the tests to run, from cli args
// - allow you to nest describes with beforeEach n stuff
// - display the sub-items of a describe as they're being run (at least sub-describes)
//   - it would be fine to use readline to replace them one after another, but I just want
//     feedback that things are happening.

Let's make sure we have issues tracking these and address what we can.

kyldvs avatar Dec 18 '19 22:12 kyldvs

haha thanks :D

jaredly avatar Dec 18 '19 23:12 jaredly

Related thread regarding the first point: https://reasonml.chat/t/running-rely-test-framework-in-watch-mode/1710

mikaello avatar Dec 18 '19 23:12 mikaello

// - allow you to select a subset of the tests to run, from cli args

I think we had to enable something like this for some of our internal infra, but I believe our solution is just to run everything (because it's fast enough) and then only report on the tests specified by CLI args

kyldvs avatar Dec 18 '19 23:12 kyldvs

That would be awesome!

davesnx avatar Dec 19 '19 19:12 davesnx

Thanks for filing this @kyldvs and for the awesome feedback @jaredly

  • watch mode is definitely something that is on the radar, as Jordan discussed in the linked thread I think we are looking into integrating that in esy to have a nice cross platform solution. The watchman script in that thread works as well.

  • Running a subset of tests is definitely something I plan on building in and will bump up in priority. As Kyle said we are currently doing this in a hacky way internally, but I've built some infrastructure that should make actually supporting this fairly straightforward.

  • @jaredly Can you elaborate more on your usecase for nesting lifecycle functions with describes?

  • I'll look into integrating sub-describes/individual tests into the default reporter. This would probably be configurable because I'm worried about the IO implications on performance.

bandersongit avatar Dec 19 '19 20:12 bandersongit

I'll look into integrating sub-describes/individual tests into the default reporter. This would probably be configurable because I'm worried about the IO implications on performance.

Would this be mean seeing each test-case (a verbose-mode if you will), something like:

[Suite 2]
- handles foo
- handles bar
[Suite 2]
- handles foo
- handles bar

If so, I'd also very much like this feature! 👍

lessp avatar May 02 '20 15:05 lessp

I'll look into integrating sub-describes/individual tests into the default reporter. This would probably be configurable because I'm worried about the IO implications on performance.

Would this be mean seeing each test-case (a verbose-mode if you will), something like:

[Suite 2]
- handles foo
- handles bar
[Suite 2]
- handles foo
- handles bar

If so, I'd also very much like this feature! 👍

That's the idea. Noted!

bandersongit avatar May 02 '20 18:05 bandersongit