reason-apollo-hooks icon indicating copy to clipboard operation
reason-apollo-hooks copied to clipboard

Make compatibility with reason-apollo optional

Open fakenickels opened this issue 5 years ago • 6 comments

Currently we require reason-apollo to be installed along with reason-apollo-hooks to ease the transition, now we can drop it and make this optional

fakenickels avatar Sep 06 '19 18:09 fakenickels

That would be very nice! There are however some useful bindings that come with reason-apollo, particularly when it comes to working with cache. ApolloClient had WriteQuery and ReadQuery for this (which could actually benefit from some improvements..) Do you think we should create our own bindings for those?

MargaretKrutikova avatar Sep 06 '19 19:09 MargaretKrutikova

I think it makes sense! Ideally we should split the bindings like react-apollo repo. common, components, hoc, hooks. Then there's react-apollo which has all of them. https://github.com/apollographql/react-apollo/tree/master/packages

cem2ran avatar Sep 09 '19 18:09 cem2ran

That would be much better indeed @cem2ran, I think I can talk with @Gregoirevda about this. It'll scale much better

fakenickels avatar Sep 10 '19 14:09 fakenickels

Sure, let's do that

Gregoirevda avatar Sep 10 '19 23:09 Gregoirevda

With Apollo Client 3.0 deprecating the react-apollo package, and the reason-apollo bindings not really being updated, isn't it better to make this package self-containing? Include the read/write query code and some of the types in this package. This also means we can easily update to the Apollo Client 3.0 beta.

jfrolich avatar Nov 28 '19 07:11 jfrolich

We could probably make this repo a monorepo and have a separated package for apollo-client

fakenickels avatar Nov 28 '19 12:11 fakenickels