bs-webapi-incubator icon indicating copy to clipboard operation
bs-webapi-incubator copied to clipboard

Published 20 hours ago • verified publisher icon reasonml-community

adding bindings to HtmlVideoElement

Open BlueHotDog opened this issue 4 years ago • 3 comments

Hi, I want to add bindings to HtmlVideoElement(defined here: https://developer.mozilla.org/en-US/docs/Web/API/HTMLVideoElement). seems like there's a missing bindings for HtmlMediaElement(also the type is missing on Ocaml Dom). Should i take a stab at it? If so, how would i do that without the relevant ocaml type?

BlueHotDog avatar Apr 12 '20 11:04 BlueHotDog

Yeah, that would be great. You can just use a local type t for now, as well as submit a PR to bs-platform to add it to Dom. Once that's been merged and released we can link the local t type to that, and it won't even be a breaking change (other than requiring an updated bs-platform).

glennsl avatar Apr 13 '20 21:04 glennsl

I have a PR up for rescript-compiler to add the phantom type to Dom. @BlueHotDog are you working on this? If not I can

illusionalsagacity avatar Aug 15 '20 03:08 illusionalsagacity

hey, i'm not working on this :) feel free to PR :)

BlueHotDog avatar Aug 16 '20 08:08 BlueHotDog