Daniel Jiang

Results 402 comments of Daniel Jiang

@SoumyaRaikwar Thank you for the PR. However, when checking the PR we find there's a misunderstanding in #22333, that this parm may still be needed in some custom cases when...

IMO, this fix MAY fix your problem, but it delays the error in normal use cases. I'm a little reluctant to make it upstream. Because in general we don't support...

The reason we chose not to support node selection in restore, is to cover the "waitForFirstConsumer" storageclasses where we need to wait for the restored pod be scheduled first before...

@ryan-a-baker Per my understanding this is a highly customized deployment approach, I'm reluctant to merge it into master. I suggest that we wait until there are enough use cases like...

@polarn @filipe-silva-magalhaes-alb @dharanui I added a comment to the PR but the author didn't reply, and I don't have AWS environment to check at this moment. If the PR does...

@kaovilai I have some questions about the priority of the issue. Is it a common scenario that BSL being modified when velero pod is not running?

IMO this will cause more confusion, when there's a system-wide resource-policy, and certain backups wanna skip using this policy. I'm tentatively putting this into "icebox", unless there are strong requirements...

@swood Thanks for this PR. Are you saying the "0 sized" layer will fail to pull from Harbor? Could you provide an image so we can easily reproduce?