Zheng Lei
Zheng Lei
Hmm... maybe it's github getting some cloud syncing problem. I don't know what did you see, but on my computer viewing this very PR, it shows my force push at...
@ezzieyguywuf Please continue. I'll reply your comments later.
I guess it's not a good time to do merge in my branch yet. So I'll leave the conflict as it for now.
> Thanks for testing. Besides the issue you encountered, a CI test failed. @realthunder , can you please have a look? Will fix soon
@adrianinsaval Can you paste your About information? I tested both your files and they work as expected.
> I think there needs to be a timeout, after which an in-progress keystroke sequence is cancelled even if the user presses no more keys. The timer in ShortcutManager is...
I see what you mean here. The thing is that `ShortcutManager` is intended to just help resolving the conflict of shortcuts, instead of replacing Qt's own private shortcut state machine...
@wwmayer New commits added for suggested changes and bug fix.
Great. I'll work on it soon.
> Can you rebase and resolve the merge conflicts? Done. Please try.