qtads icon indicating copy to clipboard operation
qtads copied to clipboard

Published 20 hours ago • verified publisher icon realnc

Port to Qt 6

Open alexispurslane opened this issue 2 years ago • 6 comments

In the interests of future maintainability and compatibility, I ported QTADS to Qt6. Everything should work identically, I just went through and replaced uses of constructs that were removed in Qt6. I also removed the uses of globalStrut entirely because according to the Qt developers it was useless and usually set to zero anyways.

I also add the capacity to accept command line flags and two flags (--help and --embed), because I need the ability to tell qtads to print out its window id for something else I'm working on. I hope you don't mind.

alexispurslane avatar Oct 28 '23 15:10 alexispurslane

I'm not familiar at all with this codebase, and not even that experienced with C++, and I'm very foggy today, so please feel free to comment/critique and ill change it to get this PR merged! :D

alexispurslane avatar Oct 28 '23 20:10 alexispurslane

Nice work. I would upload this to debian/experimental as a patch if I'm really bored or anyone ask for ;-)

a-detiste avatar Nov 15 '23 11:11 a-detiste

Any new uploads to Debian regarding TADS would be very nice. Maybe they wouldn't think TADS is obsolete.

Thanks, Jeff ( Fos1)

On Wed, Nov 15, 2023 at 5:11 AM Alexandre Detiste @.***> wrote:

Nice work. I would upload this to debian/experimental as a patch if I'm really bored or anyone ask for ;-)

— Reply to this email directly, view it on GitHub https://github.com/realnc/qtads/pull/21#issuecomment-1812311367, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDAWSLR6C4RIJH4UU2L6HLYESPPDAVCNFSM6AAAAAA6UEY4S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJSGMYTCMZWG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

fos1 avatar Nov 15 '23 11:11 fos1

it is very well alive, I enabled CI right now.

one can have a look a the build warnings if interrested

https://salsa.debian.org/games-team/qtads/-/commit/a8cf846ac80918031a37c3a33da8981cf506cec7

a-detiste avatar Nov 15 '23 11:11 a-detiste

Thank you very much for doing the work! I'll need to find some time go over it and merge it. Right now I'm kind of swamped with other things.

realnc avatar Nov 15 '23 17:11 realnc

Thank you very much for doing the work! I'll need to find some time go over it and merge it. Right now I'm kind of swamped with other things.

Thank you! And yeah that's perfectly understandable.

alexispurslane avatar Nov 15 '23 21:11 alexispurslane