realm-studio icon indicating copy to clipboard operation
realm-studio copied to clipboard

Add basic support for dark mode & update Swift schema.

Open furby-tm opened this issue 2 years ago • 5 comments

Within this PR is support for:

  • minimum, basic dark mode support (toggle-able via the View menu in the menubar).
  • updated Swift schema for the replacement of Objective-C properties with the new Swift @Persisted property wrappers.

furby-tm avatar Mar 15 '23 11:03 furby-tm

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @furby-tm. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

cla-bot[bot] avatar Mar 15 '23 11:03 cla-bot[bot]

@cla-bot check

furby-tm avatar Mar 15 '23 11:03 furby-tm

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Mar 15 '23 11:03 cla-bot[bot]

@furby-tm could you post a few screenshots from the app when in dark mode?

kraenhansen avatar Mar 16 '23 13:03 kraenhansen

Hey guys! Sorry, I'm just now getting to your response -- I've been tied down with some projects getting rolled out into production over the last couple weeks, so things have been hectic.

I had just a couple hours to spare, and spent that time trying to tone down the blinding light mode of the app, since I use it frequently, and figured my eyes could spare a break.

I realize my PR was a 0 context shove in, so I apologize for that!

To quickly summarize these changes:

I added a basic dark mode, and made some additional changes to the light mode which integrated some of the UI aspects of MongoDB Compass. The dark mode will need some cleanup since I missed a lot of the text on the tables (lots of it is looking black on black so that won't do!).

I brought in the latest changes to the realm swift generation schema, which is the removal of any/all objc boilerplate and integrated the ‘@Persisted’ swift property wrappers.

And I believe that was all. If dark mode & rolling in the latest swift schematic changes are something the realm team are looking to support I'd be happy to fixup a proper PR for your review.

furby-tm avatar Mar 21 '23 23:03 furby-tm