realm-js icon indicating copy to clipboard operation
realm-js copied to clipboard

RJS-2717: Replaced lodash with lodash.isequal

Open Ydixit007 opened this issue 1 year ago • 4 comments

What, How & Why?

Since we're only using isEqual from lodash we should avoid requiring in the entire library as it'll be difficult for end-users to shake off. Instead we could depend on the more limited lodash.isequal package.

This closes #6458 .

Ydixit007 avatar Apr 21 '24 00:04 Ydixit007

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @Ydixit007. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

cla-bot[bot] avatar Apr 21 '24 00:04 cla-bot[bot]

@cla-bot check

Ydixit007 avatar Apr 21 '24 00:04 Ydixit007

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Apr 21 '24 00:04 cla-bot[bot]

npm ERR! Missing: @types/[email protected] from lock file
npm ERR! Missing: [email protected] from lock file

You'll need to run npm install and commit the changes to the lock file 👍

kraenhansen avatar Apr 24 '24 11:04 kraenhansen