realm-js icon indicating copy to clipboard operation
realm-js copied to clipboard

Remove the type for the `Object#_objectId`

Open kraenhansen opened this issue 2 years ago • 2 comments

What, How & Why?

This closes #4820

☑️ ToDos

  • [ ] 📝 Changelog entry
  • [ ] Migrate this over to the _objectKey introduced on master (after v11 has been rebased):
  • [x] 📝 Compatibility label is updated or copied from previous entry
  • [x] 🚦 Tests
  • [x] 🔀 Executed flexible sync tests locally if modifying flexible sync
  • [x] 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • [x] 📱 Check the React Native/other sample apps work if necessary
  • [x] 📝 Public documentation PR created or is not necessary
  • [x] 💥 Breaking label has been applied or is not necessary

kraenhansen avatar Aug 23 '22 09:08 kraenhansen

LGTM. I would approve if this wasn't my own PR 🤦

kraenhansen avatar Sep 19 '22 14:09 kraenhansen

The tests seem to not be getting the _objectKey changes. I'll have to look into this before merging

takameyer avatar Sep 19 '22 15:09 takameyer