realm-dotnet
realm-dotnet copied to clipboard
realm
Use upstream pkl-gha for GitHub Action Workflows
Description
Hello Realm .NET Team 👋
It’s great to see that you’re considering using Pkl, especially pkl-gha, to configure your CI 🙂. I’ve incorporated all of your additions into the upstream project, so your customizations are no longer necessary. This means there’s no longer any maintenance overhead required on your end.
I’ve split the PR into three commits:
- Adopts the upstream project.
- Removes your custom Pkl project.
- Translates the Pkl workflows into YAML workflows.
Each of these commits can be reviewed individually.
Please note that I haven’t changed any of your logic. I’ve only replaced your implementation with the upstream project.
I hope you find this useful! Let me know if anything is missing or if there are any improvements I can make to pkl-gha. Looking forward to your review and feedback 🤝.
cc @nirinchev because you added pkl at the first place here https://github.com/realm/realm-dotnet/pull/3603 🙂
Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @StefMa. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.
![cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/2404?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey @StefMa thanks so much for this - great stuff. I was going to eventually try and submit a PR upstream for those changes, but priority reshuffles within the company meant I don't have that much time working on this project anymore. I'll try and review this over the weekend and get it in.
@nirinchev what weekned did you mean? 🤔
Just kidding 🙂 Take your time. This should act only as a friendly reminder...
Hey @StefMa, was just planning to get to it after I put some final touches on the Half Life 3 release - should be out any day now 😝
It's a fair callout - been distracted lately with other things, but will try and make time for it Very Soon™!