realm-dart icon indicating copy to clipboard operation
realm-dart copied to clipboard

Published 20 hours ago • verified publisher icon realm

Add support for datetime properties

Open nirinchev opened this issue 2 years ago • 7 comments

This depends on https://github.com/realm/realm-dart/pull/495 because I was halfway through testing dynamic access when I realized dates are not supported.

Fixes https://github.com/realm/realm-dart/issues/520

UPDATE: Superseded by #569. Kept as a draft cause it has nullable datetime support as well

nirinchev avatar Apr 28 '22 22:04 nirinchev

I filed https://github.com/realm/realm-core/issues/5451 to track fixes for roundtripping zero/negative dates. I tried it on Windows and the values look correct in Studio, so I'm 99% confident it's a serialization bug in to_json and not an actual logic issue on our end.

nirinchev avatar Apr 29 '22 09:04 nirinchev

@blagoev I think it would be nice to land this PR before release.

nielsenko avatar May 10 '22 12:05 nielsenko

This PR works around the issues with to_json on Windows, so the tests are not a blocker to merging it. It will need to be cherry picked on top of master though.

nirinchev avatar May 10 '22 13:05 nirinchev

I was planning on doing that on top of master, but it can wait a bit to one of the next sprints

blagoev avatar May 10 '22 13:05 blagoev

Added in https://github.com/realm/realm-dart/pull/569.

nirinchev avatar May 23 '22 14:05 nirinchev

reopening since this has nullable datetime support.

blagoev avatar May 23 '22 19:05 blagoev

@blagoev we already merged nullable datetime support (there was nothing special about this). Did you mean to reopen https://github.com/realm/realm-dart/pull/462? Even so, we don't really need those PRs open - they'll still be accessible via the Github UI and we can't cherry pick them anyway since they've diverged too much from master. We'll probably need to update https://github.com/realm/realm-dart/pull/459 to pull in oid and uuid support.

nirinchev avatar May 23 '22 22:05 nirinchev