realm-core icon indicating copy to clipboard operation
realm-core copied to clipboard

Published 20 hours ago • verified publisher icon realm

Send client integration errors to the server

Open danieltabacaru opened this issue 3 years ago • 2 comments

What, How & Why?

The sync protocol is updated such that JSON_ERROR messages can be sent from client to server too. The sync client sends error messages when remote changesets cannot be integrated.

This represents part 2 of error handling v2.

☑️ ToDos

  • [ ] 📝 Changelog update
  • [ ] 🚦 Tests (or not relevant)
  • [ ] ~~C-API, if public C++ API changed.~~

danieltabacaru avatar Aug 08 '22 13:08 danieltabacaru

Can we add a test for this?

jbreams avatar Aug 08 '22 17:08 jbreams

Can we add a test for this?

I am working on it. I didn't want to hold back the review while doing that :)

danieltabacaru avatar Aug 08 '22 17:08 danieltabacaru

FYI: There is one last sync test failing pending a fix.

danieltabacaru avatar Aug 16 '22 14:08 danieltabacaru

FYI: There is one last sync test failing pending a fix.

This proved to be a server issue. Since it may take a while for them to fix it, I'll disable the checks for now.

danieltabacaru avatar Sep 07 '22 16:09 danieltabacaru

Has the server merged in their fixes for this? Looks like the test for this is still failing on a few variants.

jbreams avatar Sep 07 '22 21:09 jbreams

Has the server merged in their fixes for this? Looks like the test for this is still failing on a few variants.

No. It is going to be a while. I will disable it for now. I filed a ticket to enable it when their fix is in.

danieltabacaru avatar Sep 08 '22 06:09 danieltabacaru