SwiftLint
SwiftLint copied to clipboard
realm
Migrate MultilineParametersBracketsRule from SourceKit to SwiftSyntax
Summary
Convert MultilineParametersBracketsRule to use SwiftSyntax instead of SourceKit for improved performance and better detection of multiline parameter formatting violations.
Key Technical Improvements
- Enhanced multiline detection distinguishing between structurally multiline parameters and parameters with multiline default values
- Accurate position reporting using SwiftSyntax's precise token locations
- Better handling of default values by focusing on parameter structure rather than content
- Improved performance using visitor pattern over regex-based SourceKit analysis
- Reduced false positives for single parameters with multiline default values
Migration Details
- Replaced
ASTRulewith@SwiftSyntaxRule(optIn: true)annotation - Implemented
ViolationsSyntaxVisitorpattern for function and initializer parameter analysis - Added helper methods to extract significant tokens (name/type) excluding default values
- Converted regex-based bracket detection to SwiftSyntax position comparisons
- Maintained full compatibility with existing rule behavior and test cases
| 7166 Warnings | |
|---|---|
| :warning: | This PR may need tests. |
| :warning: | This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/NowPlayingViewController.swift:208:25: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/NowPlayingViewController.swift:209:72: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:83:10: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Locations.swift:26:25: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Locations.swift:27:88: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:56:25: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:57:80: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:81:25: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:83:54: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:12:24: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:13:69: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:15:24: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:16:59: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:185:24: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:186:69: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:136:20: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:561:41: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:563:74: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Example/Source/AppDelegate.swift:35:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Example/Source/AppDelegate.swift:36:111: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Example/Source/AppDelegate.swift:47:30: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Example/Source/AppDelegate.swift:49:74: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoder.swift:75:45: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoder.swift:76:69: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoder.swift:159:45: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoder.swift:160:69: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoder.swift:209:39: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoder.swift:210:113: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoding.swift:153:17: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/ParameterEncoding.swift:155:54: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:108:17: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:118:79: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:172:29: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:182:91: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:280:23: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:286:62: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:328:57: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:334:96: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:385:63: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:392:102: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:419:29: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:424:68: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:447:29: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:449:73: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:513:49: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:515:93: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:550:24: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:557:74: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:585:58: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:592:108: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:612:24: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:614:74: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:646:24: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:648:74: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:707:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:713:61: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:732:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:735:57: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:756:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:762:61: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:782:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:785:57: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:806:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:812:61: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:832:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:835:57: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:872:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:879:61: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:922:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:926:57: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:968:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:975:61: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1015:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1019:57: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1031:17: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1034:41: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1135:33: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Session.swift:1137:92: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:124:10: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:131:39: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:280:32: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:281:94: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:299:51: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:300:94: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:320:46: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:321:89: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:373:66: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:375:129: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:415:38: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:416:78: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:466:55: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:470:92: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:575:48: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:577:114: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:150:10: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:157:39: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:483:22: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/WebSocketRequest.swift:485:94: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/RequestTaskMap.swift:39:10: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/RequestTaskMap.swift:41:86: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:65:52: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:67:73: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:150:10: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:157:44: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:338:26: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:339:99: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:364:76: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:366:172: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:446:74: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:448:170: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:465:58: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:467:154: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:481:29: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:482:101: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:501:30: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:505:103: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:530:32: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:535:107: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:562:30: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:567:102: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:593:49: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DownloadRequest.swift:599:119: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Response.swift:70:17: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Response.swift:75:49: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Response.swift:256:17: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Response.swift:262:49: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Response.swift:428:29: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Response.swift:431:57: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/UploadRequest.swift:67:10: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/UploadRequest.swift:74:39: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Request.swift:259:10: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/Request.swift:264:39: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:54:10: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:60:39: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:198:32: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:199:94: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:242:72: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:244:164: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:321:70: Warning: Opening parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | This PR introduced a violation in Alamofire: /Source/Core/DataRequest.swift:323:162: Warning: Closing parenthesis should be on a separate line when using multiline parameters (multiline_parameters_brackets) |
| :warning: | Danger found 7166 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 141. |
| 7217 Messages | |
|---|---|
| :book: | Building this branch resulted in a binary size of 25247.12 KiB vs 25244.52 KiB when built on main (0% larger). |
| :book: | Linting Aerial with this PR took 0.22 s vs 0.29 s on main (24% faster). |
| :book: | Linting Alamofire with this PR took 0.18 s vs 0.35 s on main (48% faster). |
| :book: | Linting Brave with this PR took 0.77 s vs 2.05 s on main (62% faster). |
| :book: | Linting DuckDuckGo with this PR took 2.4 s vs 5.94 s on main (59% faster). |
| :book: | Linting Firefox with this PR took 1.07 s vs 2.76 s on main (61% faster). |
| :book: | Linting Kickstarter with this PR took 0.75 s vs 2.07 s on main (63% faster). |
| :book: | Linting Moya with this PR took 0.14 s vs 0.2 s on main (30% faster). |
| :book: | Linting NetNewsWire with this PR took 0.3 s vs 0.74 s on main (59% faster). |
| :book: | Linting Nimble with this PR took 0.15 s vs 0.26 s on main (42% faster). |
| :book: | Linting PocketCasts with this PR took 0.73 s vs 1.93 s on main (62% faster). |
| :book: | Linting Quick with this PR took 0.13 s vs 0.19 s on main (31% faster). |
| :book: | Linting Realm with this PR took 0.44 s vs 1.02 s on main (56% faster). |
| :book: | Linting Sourcery with this PR took 0.28 s vs 0.58 s on main (51% faster). |
| :book: | Linting Swift with this PR took 0.46 s vs 1.18 s on main (61% faster). |
| :book: | Linting VLC with this PR took 0.21 s vs 0.4 s on main (47% faster). |
| :book: | Linting Wire with this PR took 1.87 s vs 5.22 s on main (64% faster). |
| :book: | Linting WordPress with this PR took 1.05 s vs 2.88 s on main (63% faster). |
| :book: | This PR fixed a violation in Aerial: /Resources/MainUI/Settings panels/NowPlayingViewController.swift:208:25: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Resources/MainUI/Settings panels/NowPlayingViewController.swift:209:72: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Locations.swift:26:25: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Locations.swift:27:88: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:83:10: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:56:25: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:57:80: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:81:25: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:83:54: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:185:24: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:186:69: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:136:20: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:12:24: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:13:69: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:15:24: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:16:59: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Views/AerialView.swift:561:41: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Views/AerialView.swift:563:74: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Example/Source/AppDelegate.swift:35:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Example/Source/AppDelegate.swift:36:111: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Example/Source/AppDelegate.swift:47:30: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Example/Source/AppDelegate.swift:49:74: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/ParameterEncoder.swift:75:45: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/ParameterEncoder.swift:76:69: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/ParameterEncoder.swift:159:45: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/ParameterEncoder.swift:160:69: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/ParameterEncoder.swift:209:39: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/ParameterEncoder.swift:210:113: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:108:17: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:118:79: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:172:29: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:182:91: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:280:23: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:286:62: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:328:57: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:334:96: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:385:63: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:392:102: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:419:29: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:424:68: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:447:29: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:449:73: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:513:49: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:515:93: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:550:24: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:557:74: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:585:58: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:592:108: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:612:24: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:614:74: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:646:24: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:648:74: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:707:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:713:61: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:732:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:735:57: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:756:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:762:61: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:782:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:785:57: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:806:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:812:61: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:832:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:835:57: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:872:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:879:61: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:922:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:926:57: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:968:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:975:61: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:1015:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:1019:57: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:1031:17: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:1034:41: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:1135:33: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Session.swift:1137:92: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/ParameterEncoding.swift:153:17: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/ParameterEncoding.swift:155:54: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:124:10: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:131:39: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:280:32: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:281:94: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:299:51: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:300:94: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:320:46: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:321:89: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:373:66: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:375:129: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:415:38: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:416:78: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:466:55: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:470:92: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:575:48: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DataStreamRequest.swift:577:114: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:65:52: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:67:73: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:150:10: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:157:44: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:338:26: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:339:99: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:364:76: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:366:172: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:446:74: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:448:170: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:465:58: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:467:154: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:481:29: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:482:101: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:501:30: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:505:103: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:530:32: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:535:107: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:562:30: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:567:102: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:593:49: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/DownloadRequest.swift:599:119: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/RequestTaskMap.swift:39:10: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/RequestTaskMap.swift:41:86: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/WebSocketRequest.swift:150:10: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/WebSocketRequest.swift:157:39: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/WebSocketRequest.swift:483:22: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/WebSocketRequest.swift:485:94: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/UploadRequest.swift:67:10: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/UploadRequest.swift:74:39: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Response.swift:70:17: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Response.swift:75:49: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Response.swift:256:17: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Response.swift:262:49: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Response.swift:428:29: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Response.swift:431:57: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Request.swift:259:10: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/Request.swift:264:39: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/SessionDelegate.swift:86:26: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/SessionDelegate.swift:89:116: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/SessionDelegate.swift:150:42: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :book: | This PR fixed a violation in Alamofire: /Source/Core/SessionDelegate.swift:151:74: Warning: Multiline parameters should have their surrounding brackets in a new line (multiline_parameters_brackets) |
| :warning: | Danger found 7217 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 154. |
Generated by :no_entry_sign: Danger
An analysis of the OSS Check results from Claude:
The OSS Check results show that all violations are message changes only. The violations are still correctly detected at the same locations, but with more descriptive messages:
- Old: "Multiline parameters should have their surrounding brackets in a new line"
- New: "Opening parenthesis should be on a separate line when using multiline parameters" OR "Closing parenthesis should be on a separate line when using multiline parameters"
This is an improvement because:
- Users get more specific guidance about which bracket needs fixing
- The violation location is more precise
- No false positives or false negatives were introduced
An analysis of the OSS Check results from Claude:
The OSS Check results show that all violations are message changes only. The violations are still correctly detected at the same locations, but with more descriptive messages:
- Old: "Multiline parameters should have their surrounding brackets in a new line"
- New: "Opening parenthesis should be on a separate line when using multiline parameters" OR "Closing parenthesis should be on a separate line when using multiline parameters"
This is an improvement because:
- Users get more specific guidance about which bracket needs fixing
- The violation location is more precise
- No false positives or false negatives were introduced
That cannot be entirely true. The numbers of fixed and new violations is not equal. So there must be a few that are only fixed and a few that are only new and thus have not just their message changed.
The ones I found look valid though. I'm trying to improve the categorization further in #6139.
An analysis of the OSS Check results from Claude:
The OSS Check results show that all violations are message changes only. The violations are still correctly detected at the same locations, but with more descriptive messages:
- Old: "Multiline parameters should have their surrounding brackets in a new line"
- New: "Opening parenthesis should be on a separate line when using multiline parameters" OR "Closing parenthesis should be on a separate line when using multiline parameters"
This is an improvement because:
- Users get more specific guidance about which bracket needs fixing
- The violation location is more precise
- No false positives or false negatives were introduced
That cannot be entirely true. The numbers of fixed and new violations is not equal. So there must be a few that are only fixed and a few that are only new and thus have not just their message changed.
The ones I found look valid though. I'm trying to improve the categorization further in #6139.
oss-check-summary.md is the report with improved categorization and this PR cherry-picked on top. There are indeed a few fixed and new violations that differ in more than the message.