SwiftLint
SwiftLint copied to clipboard
realm
Migrate VerticalWhitespaceClosingBracesRule to SwiftSyntax
Summary
Convert VerticalWhitespaceClosingBracesRule to use SwiftSyntax instead of SourceKit for improved performance and better detection of empty lines before closing braces.
Key Technical Improvements
- Enhanced trivia analysis for accurate empty line detection before closing braces
- Proper position calculation using positionAfterSkippingLeadingTrivia for line numbers
-
Improved trivial line detection supporting any combination of
closing braces (
},],)) - SwiftSyntax visitor pattern replacing regex-based detection for better accuracy
- Unified correction logic handling all newline types (LF, CR, CRLF) consistently
Migration Details
- Replaced
CorrectableRule, OptInRulewith@SwiftSyntaxRule(correctable: true, optIn: true) - Implemented
ViolationsSyntaxVisitorfor detecting violations in token leading trivia - Implemented
ViolationsSyntaxRewriterfor correcting violations by modifying trivia - Added proper handling of
only_enforce_before_trivial_linesconfiguration option - Maintained exact position reporting for violation locations
- Preserved all existing test cases and rule behavior
| 921 Warnings | |
|---|---|
| :warning: | This PR may need tests. |
| :warning: | This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/Collection View/PlayingCollectionViewItem.swift:51:13: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/Collection View/PlayingCollectionViewItem.swift:59:13: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/Collection View/PlayingCollectionViewItem.swift:146:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsCache.swift:69:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsAdvanced.swift:42:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceInfo.swift:169:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceInfo.swift:292:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:362:17: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:514:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Models/ErrorLog.swift:93:17: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoWeatherView.swift:74:17: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Views/MainUI/NowPlayingCollectionView.swift:29:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:428:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/CredentialProviderActivation/CredentialProviderActivatedView.swift:69:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/Shared/ActionMessageView.swift:56:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/CredentialProviderList/EmptyView.swift:47:13: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/CredentialProviderList/EmptySearchView.swift:91:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/LocalPackages/SyncUI-iOS/Sources/SyncUI-iOS/ViewModels/Internal/EditDeviceViewModel.swift:39:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/LocalPackages/SyncUI-iOS/Sources/SyncUI-iOS/Views/Internal/BackButtonModifier.swift:61:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/Core/SchemeHandler.swift:93:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2535:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2546:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2555:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/Core/Pixel.swift:330:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/AtbUITests/AtbIntegrationTests.swift:136:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/BulkGeneratorView.swift:39:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/BulkGeneratorView.swift:141:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/BulkGeneratorView.swift:172:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/UITableViewCellExtension.swift:37:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/FireproofingAlert.swift:91:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/FireproofingAlert.swift:93:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Configuration/ConfigurationManager.swift:58:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Configuration/ConfigurationManager.swift:213:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AutoClear.swift:33:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/CreditCardRow/CreditCardRowViewModel.swift:111:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/NetworkProtectionDebugViewController.swift:672:13: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabsBarCell.swift:72:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabsBarCell.swift:116:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabsBarCell.swift:131:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabsBarCell.swift:172:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/ToggleExpandButtonStyle.swift:44:25: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/DaxDialogs.swift:30:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/DaxDialogs.swift:73:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/DaxDialogs.swift:84:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AppLifecycle/AppStates/Launching.swift:186:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:95:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:99:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:107:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:115:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:119:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:127:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:131:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:135:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:139:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/DataBrokerProtectionDebugViewController.swift:275:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+Segues.swift:373:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/UserScripts.swift:153:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AlertPlaygroundView.swift:39:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AlertPlaygroundView.swift:63:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AlertPlaygroundView.swift:138:29: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AlertPlaygroundView.swift:164:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AppUserDefaults.swift:161:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AppUserDefaults.swift:175:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AppUserDefaults.swift:191:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/FeedbackFormViewController.swift:311:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AppConfigurationFetch.swift:70:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AppConfigurationFetch.swift:97:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/FeedbackViewController.swift:94:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/PrivacyIconView.swift:194:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/SettingsViewModel.swift:921:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/DesktopDownloadViewModel.swift:49:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingExperiment/AddressBarPositionPicker/OnboardingAddressBarPositionPicker.swift:106:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingExperiment/Styles/DaxDialogStyles.swift:70:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:1073:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:1115:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:1405:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:2652:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:2918:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:2927:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:3047:13: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:3362:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:3567:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:3576:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingExperiment/Pixels/OnboardingPixelReporter.swift:375:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingExperiment/OnboardingIntro/OnboardingView.swift:283:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AutocompleteViewControllerDelegate.swift:34:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/BookmarksDatabaseSetup.swift:209:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OngoingDownloadRow.swift:57:13: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:114:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewCell.swift:30:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/DuckPlayerDebugSettingsView.swift:64:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AutoconsentSettingsViewController.swift:81:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MaliciousSiteProtection/MaliciousSiteProtectionManager.swift:66:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MaliciousSiteProtection/MaliciousSiteProtectionManager.swift:100:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AppRatingPrompt.swift:34:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AppRatingPrompt.swift:77:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AppRatingPrompt.swift:159:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MaliciousSiteProtection/Events/MaliciousSiteProtectionEventMapper.swift:41:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AutofillLoginDetailsViewModel.swift:475:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:466:13: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:689:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:2102:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:2243:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:3087:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:3343:13: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:3348:13: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:3350:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/CheckDefaultBrowser/DefaultBrowserManager.swift:157:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/CheckDefaultBrowser/DefaultBrowserInfoStore.swift:40:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/BookmarksTextFieldCell.swift:43:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/SettingsDebugView.swift:35:17: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/SettingsDebugView.swift:40:2: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/ViewVisibility.swift:28:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabDelegate.swift:116:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/DataImport/ZipContentSelectionViewController.swift:66:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/BookmarksDelegate.swift:26:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionExternalLinkViewModel.swift:73:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionITPViewModel.swift:91:17: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionITPViewModel.swift:197:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionRestoreViewModel.swift:95:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionRestoreViewModel.swift:171:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionFlowViewModel.swift:150:8: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionFlowViewModel.swift:204:17: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionFlowViewModel.swift:349:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionEmailViewModel.swift:281:9: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/AsyncHeadlessWebview/AsyncHeadlessWebViewModel.swift:70:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/AsyncHeadlessWebview/HeadlessWebViewCoordinator.swift:114:3: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/AsyncHeadlessWebview/HeadlessWebViewCoordinator.swift:195:17: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/AsyncHeadlessWebview/HeadlessWebViewCoordinator.swift:236:5: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | Danger found 921 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 130. |
| 891 Messages | |
|---|---|
| :book: | Building this branch resulted in a binary size of 25267.66 KiB vs 25245.04 KiB when built on main (0% larger). |
| :book: | Linting Aerial with this PR took 0.18 s vs 0.3 s on main (40% faster). |
| :book: | Linting Alamofire with this PR took 0.18 s vs 0.37 s on main (51% faster). |
| :book: | Linting Brave with this PR took 0.75 s vs 2.19 s on main (65% faster). |
| :book: | Linting DuckDuckGo with this PR took 2.41 s vs 6.18 s on main (61% faster). |
| :book: | Linting Firefox with this PR took 1.02 s vs 2.95 s on main (65% faster). |
| :book: | Linting Kickstarter with this PR took 0.75 s vs 2.21 s on main (66% faster). |
| :book: | Linting Moya with this PR took 0.14 s vs 0.21 s on main (33% faster). |
| :book: | Linting NetNewsWire with this PR took 0.31 s vs 0.79 s on main (60% faster). |
| :book: | Linting Nimble with this PR took 0.16 s vs 0.28 s on main (42% faster). |
| :book: | Linting PocketCasts with this PR took 0.71 s vs 2.05 s on main (65% faster). |
| :book: | Linting Quick with this PR took 0.13 s vs 0.2 s on main (35% faster). |
| :book: | Linting Realm with this PR took 0.43 s vs 1.07 s on main (59% faster). |
| :book: | Linting Sourcery with this PR took 0.29 s vs 0.62 s on main (53% faster). |
| :book: | Linting Swift with this PR took 0.44 s vs 1.24 s on main (64% faster). |
| :book: | Linting VLC with this PR took 0.21 s vs 0.42 s on main (50% faster). |
| :book: | Linting Wire with this PR took 1.86 s vs 5.63 s on main (66% faster). |
| :book: | Linting WordPress with this PR took 1.01 s vs 3.06 s on main (66% faster). |
| :book: | This PR fixed a violation in Aerial: /Resources/MainUI/Settings panels/Collection View/PlayingCollectionViewItem.swift:51:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in Aerial: /Resources/MainUI/Settings panels/Collection View/PlayingCollectionViewItem.swift:59:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in Aerial: /Resources/MainUI/Settings panels/Collection View/PlayingCollectionViewItem.swift:146:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsCache.swift:69:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsAdvanced.swift:42:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Aerial.swift:362:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:514:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Models/ErrorLog.swift:93:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoWeatherView.swift:74:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Views/MainUI/NowPlayingCollectionView.swift:29:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in Aerial: /Aerial/Source/Views/AerialView.swift:428:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/CredentialProviderActivation/CredentialProviderActivatedView.swift:69:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/Shared/ActionMessageView.swift:56:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/CredentialProviderList/EmptyView.swift:47:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/CredentialProviderList/EmptySearchView.swift:91:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/LocalPackages/SyncUI-iOS/Sources/SyncUI-iOS/ViewModels/Internal/EditDeviceViewModel.swift:39:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/LocalPackages/SyncUI-iOS/Sources/SyncUI-iOS/Views/Internal/BackButtonModifier.swift:61:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/Core/SchemeHandler.swift:93:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2535:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2546:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/Core/PixelEvent.swift:2555:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/Core/Pixel.swift:330:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/AtbUITests/AtbIntegrationTests.swift:136:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/BulkGeneratorView.swift:39:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/BulkGeneratorView.swift:141:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/BulkGeneratorView.swift:172:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/UITableViewCellExtension.swift:37:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/FireproofingAlert.swift:91:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/FireproofingAlert.swift:93:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Configuration/ConfigurationManager.swift:58:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Configuration/ConfigurationManager.swift:213:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AutoClear.swift:33:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/CreditCardRow/CreditCardRowViewModel.swift:111:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/NetworkProtectionDebugViewController.swift:672:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabsBarCell.swift:72:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabsBarCell.swift:116:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabsBarCell.swift:131:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabsBarCell.swift:172:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/ToggleExpandButtonStyle.swift:44:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/DaxDialogs.swift:30:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/DaxDialogs.swift:73:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/DaxDialogs.swift:84:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AppLifecycle/AppStates/Launching.swift:186:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:95:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:99:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:107:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:115:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:119:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:127:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:131:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:135:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OmniBarDelegate.swift:139:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+Segues.swift:373:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AlertPlaygroundView.swift:39:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AlertPlaygroundView.swift:63:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AlertPlaygroundView.swift:138:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AlertPlaygroundView.swift:164:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AppUserDefaults.swift:161:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AppUserDefaults.swift:175:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AppUserDefaults.swift:191:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/UserScripts.swift:153:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/FeedbackFormViewController.swift:311:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/FeedbackViewController.swift:94:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/SettingsViewModel.swift:921:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/PrivacyIconView.swift:194:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AppConfigurationFetch.swift:70:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AppConfigurationFetch.swift:97:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:1073:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:1115:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:1405:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:2652:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:2918:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:2927:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:3047:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:3362:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:3567:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:3576:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/DesktopDownloadViewModel.swift:49:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingExperiment/AddressBarPositionPicker/OnboardingAddressBarPositionPicker.swift:106:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingExperiment/Styles/DaxDialogStyles.swift:70:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingExperiment/Pixels/OnboardingPixelReporter.swift:375:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingExperiment/OnboardingIntro/OnboardingView.swift:283:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AutocompleteViewControllerDelegate.swift:34:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/BookmarksDatabaseSetup.swift:209:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/OngoingDownloadRow.swift:57:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:114:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewCell.swift:30:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:466:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:689:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:2102:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:2243:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:3087:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:3343:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:3348:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:3350:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/DuckPlayerDebugSettingsView.swift:64:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AutoconsentSettingsViewController.swift:81:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AppRatingPrompt.swift:34:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AppRatingPrompt.swift:77:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AppRatingPrompt.swift:159:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MaliciousSiteProtection/MaliciousSiteProtectionManager.swift:66:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MaliciousSiteProtection/MaliciousSiteProtectionManager.swift:100:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/MaliciousSiteProtection/Events/MaliciousSiteProtectionEventMapper.swift:41:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AutofillLoginDetailsViewModel.swift:475:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/CheckDefaultBrowser/DefaultBrowserInfoStore.swift:40:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/CheckDefaultBrowser/DefaultBrowserManager.swift:157:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/BookmarksTextFieldCell.swift:43:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/SettingsDebugView.swift:35:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/SettingsDebugView.swift:40:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/TabDelegate.swift:116:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/DataImport/ZipContentSelectionViewController.swift:66:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/BookmarksDelegate.swift:26:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionExternalLinkViewModel.swift:73:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionFlowViewModel.swift:150:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionFlowViewModel.swift:204:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionFlowViewModel.swift:349:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionITPViewModel.swift:91:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionITPViewModel.swift:197:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionEmailViewModel.swift:281:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/AsyncHeadlessWebview/AsyncHeadlessWebViewModel.swift:70:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionRestoreViewModel.swift:95:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/ViewModel/SubscriptionRestoreViewModel.swift:171:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/AsyncHeadlessWebview/HeadlessWebViewCoordinator.swift:114:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :book: | This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/AsyncHeadlessWebview/HeadlessWebViewCoordinator.swift:195:1: Warning: Don't include vertical whitespace (empty line) before closing braces (vertical_whitespace_closing_braces) |
| :warning: | Danger found 891 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 142. |
Generated by :no_entry_sign: Danger
With this rewrite, we see new violations on empty lines preceded by a comment, that is:
func f() {
// comment
↓
}
That's reasonable. So all OSS findings are fine.