SwiftLint
SwiftLint copied to clipboard
realm
Update non_optional_string_data_conversion rule docs and examples to make it more clear
Motivation:
The rule non_optional_string_data_conversion is bidirectional it is triggered when converting string to data as well as when converting from data to string so this behaviour is needed to be clearly documented.
Changes:
- Updated the description to clearly show that the rule will be triggered in both scenarios with the references to preferred initialisers
- Updated triggering and non-triggering examples
| 390 Warnings | |
|---|---|
| :warning: | If this is a user-facing change, please include a CHANGELOG entry to credit yourself! You can find it at CHANGELOG.md. |
| :warning: | This PR introduced a violation in Brave: /ios/brave-ios/App/BraveWidgets/LockScreenFavoriteWidget.swift:181:7: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in Brave: /ios/brave-ios/App/l10n/tools/download-translations-from-transifex.swift:108:22: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in Brave: /ios/brave-ios/Tests/BraveNewsTests/OPMLParsingTests.swift:50:30: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in Brave: /ios/brave-ios/Tests/BraveNewsTests/OPMLParsingTests.swift:53:7: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in Brave: /ios/brave-ios/Tests/SharedTests/HexExtensionsTests.swift:11:7: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in Brave: /ios/brave-ios/Tests/SharedTests/HexExtensionsTests.swift:15:7: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/AdBlock/AdBlockEngineManager.swift:370:17: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/SecureVaultStorage/DataBrokerProtectionCryptoProvider.swift:25:16: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/CCF/DataBrokerProtectionUtils.swift:110:28: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/CCF/DataBrokerProtectionUtils.swift:204:16: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Statistics/ATB/AtbParserTests.swift:25:24: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Services/BWEncryptionTests.swift:40:55: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Services/BWEncryptionTests.swift:49:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Services/BWEncryptionTests.swift:67:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:26:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:32:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:42:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:62:23: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:80:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:102:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:121:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:134:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/Tab+WKUIDelegateTests.swift:33:34: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/DownloadListStoreTests.swift:45:64: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/DownloadsTabExtensionTests.swift:36:34: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/ProgressExtensionTests.swift:28:38: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataExport/MockSecureVault.swift:31:27: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/DataExport/MockSecureVault.swift:291:95: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/DataEncryptionTests.swift:27:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/DataEncryptionTests.swift:59:26: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:26:28: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:107:46: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:108:46: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:109:46: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:112:24: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:118:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/UnitTests/Common/Extensions/FileManagerExtensionTests.swift:27:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/IntegrationTests/App/WindowManagerStateRestorationTests.swift:57:39: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/IntegrationTests/App/WindowManagerStateRestorationTests.swift:62:39: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/IntegrationTests/App/WindowManagerStateRestorationTests.swift:70:39: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /macOS/IntegrationTests/App/WindowManagerStateRestorationTests.swift:78:39: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:54:25: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:70:25: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:95:25: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:108:25: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:124:31: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:145:29: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/SecureVaultFactoryTests.swift:30:27: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/GRDBSecureStorageDatabaseProviderTests.swift:106:18: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/GRDBSecureStorageDatabaseProviderTests.swift:113:62: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/SecureStorageCryptoProviderTests.swift:40:26: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/SecureStorageCryptoProviderTests.swift:54:26: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/SecureStorageCryptoProviderTests.swift:63:26: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/UserScriptTests/UserScriptEncrypterTests.swift:33:52: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DuckPlayerTests/DuckPlayerContingencyHandlerTests.swift:112:5: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DuckPlayerTests/DuckPlayerContingencyHandlerTests.swift:140:5: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DuckPlayerTests/DuckPlayerContingencyHandlerTests.swift:169:5: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DuckPlayerTests/DuckPlayerContingencyHandlerTests.swift:199:5: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/PersistenceTests/KeyValueFileStoreTests.swift:77:19: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/PersistenceTests/KeyValueFileStoreTests.swift:92:63: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/CrashesTests/CrashCollectionTests.swift:78:21: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/CrashesTests/CrashCollectionTests.swift:109:21: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/CrashesTests/CrashCollectionTests.swift:140:21: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/DDGSyncTests.swift:53:103: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/DDGSyncTests.swift:54:101: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/DDGSyncTests.swift:55:96: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncQueueTests.swift:48:29: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncQueueTests.swift:49:28: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncQueueTests.swift:107:38: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncOperationTests.swift:49:29: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncOperationTests.swift:50:28: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncOperationTests.swift:217:38: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/Mocks/Mocks.swift:37:25: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/Mocks/Mocks.swift:38:24: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:134:20: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:144:31: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:145:32: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:153:13: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:162:13: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:169:28: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:176:35: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:184:40: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:192:41: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:200:52: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:208:56: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:216:42: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:263:79: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:302:99: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:357:67: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/PixelExperimentKitTests/PixelExperimentKitTests.swift:26:29: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/SubscriptionEndpointServiceTests.swift:81:43: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/SubscriptionEndpointServiceTests.swift:158:43: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/SubscriptionEndpointServiceTests.swift:236:43: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | This PR introduced a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/SubscriptionEndpointServiceTests.swift:310:43: Warning: Prefer the non-optional initializers when converting between String and Data (e.g. Data(_:) and String(decoding:as:)) (non_optional_string_data_conversion) |
| :warning: | Danger found 390 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 95. |
| 407 Messages | |
|---|---|
| :book: | Building this branch resulted in the same binary size as when built on main. |
| :book: | Linting Aerial with this PR took 0.19 s vs 0.17 s on main (11% slower). |
| :book: | Linting Alamofire with this PR took 0.17 s vs 0.17 s on main (0% slower). |
| :book: | Linting Brave with this PR took 0.74 s vs 0.73 s on main (1% slower). |
| :book: | Linting DuckDuckGo with this PR took 5.15 s vs 5.15 s on main (0% slower). |
| :book: | Linting Firefox with this PR took 0.98 s vs 0.99 s on main (1% faster). |
| :book: | Linting Kickstarter with this PR took 0.73 s vs 0.73 s on main (0% slower). |
| :book: | Linting Moya with this PR took 0.13 s vs 0.14 s on main (7% faster). |
| :book: | Linting NetNewsWire with this PR took 0.29 s vs 0.29 s on main (0% slower). |
| :book: | Linting Nimble with this PR took 0.15 s vs 0.15 s on main (0% slower). |
| :book: | Linting PocketCasts with this PR took 0.7 s vs 0.69 s on main (1% slower). |
| :book: | Linting Quick with this PR took 0.13 s vs 0.13 s on main (0% slower). |
| :book: | Linting Realm with this PR took 0.42 s vs 0.42 s on main (0% slower). |
| :book: | Linting Sourcery with this PR took 0.28 s vs 0.28 s on main (0% slower). |
| :book: | Linting Swift with this PR took 0.43 s vs 0.42 s on main (2% slower). |
| :book: | Linting VLC with this PR took 0.2 s vs 0.2 s on main (0% slower). |
| :book: | Linting Wire with this PR took 1.77 s vs 1.75 s on main (1% slower). |
| :book: | Linting WordPress with this PR took 0.98 s vs 1.02 s on main (3% faster). |
| :book: | This PR fixed a violation in Brave: /ios/brave-ios/App/BraveWidgets/LockScreenFavoriteWidget.swift:181:7: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in Brave: /ios/brave-ios/App/l10n/tools/download-translations-from-transifex.swift:108:22: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in Brave: /ios/brave-ios/Tests/BraveNewsTests/OPMLParsingTests.swift:50:30: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in Brave: /ios/brave-ios/Tests/BraveNewsTests/OPMLParsingTests.swift:53:7: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in Brave: /ios/brave-ios/Tests/SharedTests/HexExtensionsTests.swift:11:7: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in Brave: /ios/brave-ios/Tests/SharedTests/HexExtensionsTests.swift:15:7: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in Brave: /ios/brave-ios/Sources/Brave/WebFilters/AdBlock/AdBlockEngineManager.swift:370:17: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Statistics/ATB/AtbParserTests.swift:25:24: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Services/BWEncryptionTests.swift:40:55: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Services/BWEncryptionTests.swift:49:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Services/BWEncryptionTests.swift:67:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:26:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:32:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:42:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:62:23: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:80:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:102:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:121:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/PasswordManagers/Bitwarden/Model/BWResponseTests.swift:134:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/Tab+WKUIDelegateTests.swift:33:34: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/DownloadListStoreTests.swift:45:64: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/ProgressExtensionTests.swift:28:38: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/FileDownload/DownloadsTabExtensionTests.swift:36:34: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/DataExport/MockSecureVault.swift:31:27: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/DataExport/MockSecureVault.swift:291:95: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/DataEncryptionTests.swift:27:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/DataEncryptionTests.swift:59:26: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:26:28: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:107:46: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:108:46: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:109:46: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:112:24: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Common/FileSystem/FileStoreTests.swift:118:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/UnitTests/Common/Extensions/FileManagerExtensionTests.swift:27:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/IntegrationTests/App/WindowManagerStateRestorationTests.swift:57:39: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/IntegrationTests/App/WindowManagerStateRestorationTests.swift:62:39: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/IntegrationTests/App/WindowManagerStateRestorationTests.swift:70:39: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /macOS/IntegrationTests/App/WindowManagerStateRestorationTests.swift:78:39: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:54:25: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:70:25: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:95:25: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:108:25: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:124:31: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkProtectionTests/NetworkProtectionClientTests.swift:145:29: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/GRDBSecureStorageDatabaseProviderTests.swift:106:18: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/GRDBSecureStorageDatabaseProviderTests.swift:113:62: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/SecureStorageCryptoProviderTests.swift:40:26: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/SecureStorageCryptoProviderTests.swift:54:26: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/SecureStorageCryptoProviderTests.swift:63:26: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SecureStorageTests/SecureVaultFactoryTests.swift:30:27: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/UserScriptTests/UserScriptEncrypterTests.swift:33:52: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DuckPlayerTests/DuckPlayerContingencyHandlerTests.swift:112:5: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DuckPlayerTests/DuckPlayerContingencyHandlerTests.swift:140:5: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DuckPlayerTests/DuckPlayerContingencyHandlerTests.swift:169:5: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DuckPlayerTests/DuckPlayerContingencyHandlerTests.swift:199:5: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/PersistenceTests/KeyValueFileStoreTests.swift:77:19: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/PersistenceTests/KeyValueFileStoreTests.swift:92:63: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/CrashesTests/CrashCollectionTests.swift:78:21: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/CrashesTests/CrashCollectionTests.swift:109:21: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/CrashesTests/CrashCollectionTests.swift:140:21: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncQueueTests.swift:48:29: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncQueueTests.swift:49:28: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncQueueTests.swift:107:38: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/DDGSyncTests.swift:53:103: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/DDGSyncTests.swift:54:101: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/DDGSyncTests.swift:55:96: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncOperationTests.swift:49:29: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncOperationTests.swift:50:28: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/SyncOperationTests.swift:217:38: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/Mocks/Mocks.swift:37:25: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/DDGSyncTests/Mocks/Mocks.swift:38:24: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/PixelExperimentKitTests/PixelExperimentKitTests.swift:26:29: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:134:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:144:31: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:145:32: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:153:13: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:162:13: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:169:28: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:176:35: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:184:40: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:192:41: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:200:52: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:208:56: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:216:42: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:263:79: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:302:99: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NavigationTests/Helpers/DistributedNavigationDelegateTestsHelpers.swift:357:67: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/SubscriptionEndpointServiceTests.swift:81:43: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/SubscriptionEndpointServiceTests.swift:158:43: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/SubscriptionEndpointServiceTests.swift:236:43: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/SubscriptionEndpointServiceTests.swift:310:43: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/AuthEndpointServiceTests.swift:77:43: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/AuthEndpointServiceTests.swift:138:43: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/AuthEndpointServiceTests.swift:208:43: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SubscriptionTests/API/AuthEndpointServiceTests.swift:278:43: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkingTests/v2/APIRequestV2Tests.swift:30:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/NetworkingTests/v2/APIRequestV2Tests.swift:72:20: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SyncDataProvidersTests/Credentials/SyncableCredentialsValidationTests.swift:31:24: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SyncDataProvidersTests/Credentials/CredentialsProviderTests.swift:224:53: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :book: | This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Tests/SyncDataProvidersTests/Credentials/CredentialsProviderTests.swift:313:32: Warning: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion) |
| :warning: | Danger found 407 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 118. |
Here's an example of your CHANGELOG entry:
* Update non_optional_string_data_conversion rule docs and examples to make it more clear.
[SergeyPekar](https://github.com/SergeyPekar)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)
note: There are two invisible spaces after the entry's text.
Generated by :no_entry_sign: Danger
Thanks for the contribution!
However, this rule doesn't actually work in both directions. There are
optional_data_string_conversionandnon_optional_string_data_conversionwhich separate both cases from each other.
Thanks for the contribution!
However, this rule doesn't actually work in both directions. There are
optional_data_string_conversionandnon_optional_string_data_conversionwhich separate both cases from each other.
Yes. Looks like it was a bug of 0.55.1 (see the screenshot) that is already fixed
@SergeyPekar: Do you still fancy to add more documentation? If not, please close the PR at will.
@SergeyPekar: Do you still fancy to add more documentation? If not, please close the PR at will.
I will take a look during the week and close the PR if I won't come up with anything fancy