Teststate enhancement

Open aydinomer00 opened this issue 1 year ago • 1 comments

Description

This PR adds an exception for @TestState usage in the QuickDiscouragedCallRule. The rule now excludes @TestState declarations inside describe and context blocks.

Changes Made

Updated QuickDiscouragedCallRule to add an exception for @TestState.
Added relevant test cases in QuickDiscouragedCallRuleTests.
Updated CHANGELOG.md to include details about this enhancement.

Current Issues

While the implementation and tests were added successfully, the CI/CD pipeline is failing due to issues in:

IntegrationTests
SwiftLintFrameworkTests

I am currently unable to resolve these failing tests and would appreciate any guidance or suggestions to address them.

Thank you for your support and patience as I work through this contribution!

Dec 28 '24 16:12 aydinomer00

17 Messages

:book: Linting Aerial with this PR took 0.97s vs 0.94s on main (3% slower)

:book: Linting Alamofire with this PR took 1.3s vs 1.28s on main (1% slower)

:book: Linting Brave with this PR took 6.69s vs 6.73s on main (0% faster)

:book: Linting DuckDuckGo with this PR took 5.55s vs 5.57s on main (0% faster)

:book: Linting Firefox with this PR took 11.08s vs 11.18s on main (0% faster)

:book: Linting Kickstarter with this PR took 10.45s vs 10.43s on main (0% slower)

:book: Linting Moya with this PR took 0.54s vs 0.53s on main (1% slower)

:book: Linting NetNewsWire with this PR took 2.97s vs 3.03s on main (1% faster)

:book: Linting Nimble with this PR took 0.8s vs 0.8s on main (0% slower)

:book: Linting PocketCasts with this PR took 8.82s vs 8.72s on main (1% slower)

:book: Linting Quick with this PR took 0.45s vs 0.46s on main (2% faster)

:book: Linting Realm with this PR took 4.56s vs 4.56s on main (0% slower)

:book: Linting Sourcery with this PR took 2.34s vs 2.36s on main (0% faster)

:book: Linting Swift with this PR took 4.61s vs 4.59s on main (0% slower)

:book: Linting VLC with this PR took 1.27s vs 1.28s on main (0% faster)

:book: Linting Wire with this PR took 18.72s vs 18.74s on main (0% faster)

:book: Linting WordPress with this PR took 11.66s vs 11.63s on main (0% slower)

	17 Messages
:book:	Linting Aerial with this PR took 0.97s vs 0.94s on main (3% slower)
:book:	Linting Alamofire with this PR took 1.3s vs 1.28s on main (1% slower)
:book:	Linting Brave with this PR took 6.69s vs 6.73s on main (0% faster)
:book:	Linting DuckDuckGo with this PR took 5.55s vs 5.57s on main (0% faster)
:book:	Linting Firefox with this PR took 11.08s vs 11.18s on main (0% faster)
:book:	Linting Kickstarter with this PR took 10.45s vs 10.43s on main (0% slower)
:book:	Linting Moya with this PR took 0.54s vs 0.53s on main (1% slower)
:book:	Linting NetNewsWire with this PR took 2.97s vs 3.03s on main (1% faster)
:book:	Linting Nimble with this PR took 0.8s vs 0.8s on main (0% slower)
:book:	Linting PocketCasts with this PR took 8.82s vs 8.72s on main (1% slower)
:book:	Linting Quick with this PR took 0.45s vs 0.46s on main (2% faster)
:book:	Linting Realm with this PR took 4.56s vs 4.56s on main (0% slower)
:book:	Linting Sourcery with this PR took 2.34s vs 2.36s on main (0% faster)
:book:	Linting Swift with this PR took 4.61s vs 4.59s on main (0% slower)
:book:	Linting VLC with this PR took 1.27s vs 1.28s on main (0% faster)
:book:	Linting Wire with this PR took 18.72s vs 18.74s on main (0% faster)
:book:	Linting WordPress with this PR took 11.66s vs 11.63s on main (0% slower)

Generated by :no_entry_sign: Danger

Dec 28 '24 17:12 SwiftLintBot