SwiftLint
SwiftLint copied to clipboard
Rule Request: [empty_catch]
New Issue Checklist
- [x] Updated SwiftLint to the latest version
- [x] I searched for existing GitHub issues
New rule request
Please describe the rule idea, format
this issue's title as Rule Request: [Rule Name]
and describe:
- Why should this rule be added? Share links to existing discussion about what the community thinks about this.
I think we should have a rule that triggers when someone writes a do-catch
, and leaves the catch
empty. Cases like this should just use try?
- Provide several examples of what would and wouldn't trigger violations.
Bad
do {
try doStuff()
} catch {
}
Good
do {
try doStuff()
} catch {
Logger().error("\(error.localizedDescription)")
}
- Should the rule be configurable, if so what parameters should be configurable?
no configuration needed
- Should the rule be opt-in or enabled by default? Why? See README.md for guidelines on when to mark a rule as opt-in.
I think this should be enabled by default, although I can understand the amount of noise that might cause for existing projects.