SwiftLint icon indicating copy to clipboard operation
SwiftLint copied to clipboard

Ignore completely empty enum arguments

Open SimplyDanny opened this issue 1 year ago • 2 comments

The Swift compiler now complains about these anyway.

Fixes #5269 indirectly.

SimplyDanny avatar Oct 15 '23 11:10 SimplyDanny

21 Messages
:book: Linting Aerial with this PR took 1.17s vs 1.17s on main (0% slower)
:book: Linting Alamofire with this PR took 1.55s vs 1.54s on main (0% slower)
:book: Linting Brave with this PR took 8.77s vs 8.77s on main (0% slower)
:book: Linting DuckDuckGo with this PR took 4.39s vs 4.4s on main (0% faster)
:book: Linting Firefox with this PR took 10.32s vs 10.36s on main (0% faster)
:book: Linting Kickstarter with this PR took 10.83s vs 10.87s on main (0% faster)
:book: Linting Moya with this PR took 0.62s vs 0.62s on main (0% slower)
:book: Linting NetNewsWire with this PR took 3.25s vs 3.24s on main (0% slower)
:book: Linting Nimble with this PR took 0.81s vs 0.81s on main (0% slower)
:book: Linting PocketCasts with this PR took 8.61s vs 8.62s on main (0% faster)
:book: Linting Quick with this PR took 0.39s vs 0.39s on main (0% slower)
:book: Linting Realm with this PR took 11.55s vs 11.6s on main (0% faster)
:book: Linting Sourcery with this PR took 2.79s vs 2.8s on main (0% faster)
:book: Linting Swift with this PR took 5.2s vs 5.2s on main (0% slower)
:book: Linting VLC with this PR took 1.54s vs 1.54s on main (0% slower)
:book: Linting Wire with this PR took 19.11s vs 19.14s on main (0% faster)
:book: Linting WordPress with this PR took 13.04s vs 13.04s on main (0% slower)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/FeedbinAccountDelegate.swift:84:17: warning: Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated values if they are not used (empty_enum_arguments)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/FeedbinAccountDelegate.swift:88:19: warning: Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated values if they are not used (empty_enum_arguments)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/NewsBlurAccountDelegate.swift:363:18: warning: Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated values if they are not used (empty_enum_arguments)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/ReaderAPIAccountDelegate.swift:111:17: warning: Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated values if they are not used (empty_enum_arguments)

Generated by :no_entry_sign: Danger

SwiftLintBot avatar Oct 15 '23 11:10 SwiftLintBot

For enum cases with associated values of type Void it's allowed to keep the empty parentheses. That's impossible to know on syntax-level. So we have to accept false positives - probably the existing ones; not the new ones introduced by this PR.

SimplyDanny avatar Oct 15 '23 21:10 SimplyDanny