SwiftLint icon indicating copy to clipboard operation
SwiftLint copied to clipboard

Refactor `statement_position` rule to use `SwiftSyntax`

Open enebin opened this issue 1 year ago • 6 comments

This PR aims to resolve #4632 by refactoring the code to use SwiftSyntax instead of Regex. The new implementation provides a more reliable and robust solution.

  • With these changes, the issue #4632 is fixed and lint no longer throws a warning (or error) for one-line statement case
  • In addition, now it can catch the case that wasn't caught before, like this code.
  • Throughout the refactoring process, I tried to maintain the original error and test cases as many as possible.
  • I also added more examples with complete syntax.

This is my first pull request for this library's source code so... please let me know if I did anything incorrectly 🙏

enebin avatar May 02 '23 04:05 enebin

318 Warnings
:warning: Big PR
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:131:13: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Tabs/TabBar/TabBarCell.swift:123:5: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in Brave: /Sources/BraveWallet/Crypto/Stores/UserAssetsStore.swift:211:5: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in Brave: /Sources/BraveWallet/Crypto/Stores/UserAssetsStore.swift:214:5: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in Firefox: /firefox-ios/Client/Frontend/Browser/Authenticator.swift:105:13: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in Firefox: /firefox-ios/Client/Frontend/Browser/Authenticator.swift:116:13: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in Firefox: /firefox-ios/Client/Frontend/Library/Bookmarks/BookmarkDetailPanel.swift:254:21: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in Firefox: /firefox-ios/Storage/ThirdParty/SwiftData.swift:1082:13: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/Account.swift:1478:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/Account.swift:1481:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/Account.swift:254:5: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/FeedbinAccountDelegate.swift:1143:7: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/FeedbinAccountDelegate.swift:697:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/FeedbinAccountDelegate.swift:944:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/NewsBlurAccountDelegate+Internal.swift:115:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/NewsBlurAccountDelegate+Internal.swift:416:7: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/AccountManager.swift:107:3: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/AccountManager.swift:162:3: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/AccountManager.swift:450:13: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/AccountManager.swift:535:3: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/Feed.swift:117:5: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/Feed.swift:47:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/Feed.swift:98:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Sources/Account/Feedly/Operations/FeedlyAddNewFeedOperation.swift:140:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Tests/AccountTests/TestAccountManager.swift:45:3: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Account/Tests/AccountTests/TestAccountManager.swift:48:3: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Articles/Sources/Articles/Article.swift:49:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Articles/Sources/Articles/Author.swift:30:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Articles/Sources/Articles/Author.swift:50:3: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Articles/Sources/Articles/Author.swift:79:3: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/FeedFinder.swift:109:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/FeedFinder.swift:120:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/FeedFinder.swift:124:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/FeedFinder.swift:87:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/FeedSpecifier.swift:76:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/HTMLFeedFinder.swift:53:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/AppDefaults.swift:113:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/AppDefaults.swift:461:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/AppDelegate.swift:126:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/AppDelegate.swift:154:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/AppDelegate.swift:188:3: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/AppDelegate.swift:624:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/Inspector/InspectorWindowController.swift:70:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/Inspector/InspectorWindowController.swift:83:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/Inspector/NothingInspectorViewController.swift:42:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Detail/DetailContainerView.swift:70:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Detail/DetailStatusBarView.swift:28:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Detail/DetailStatusBarView.swift:71:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/IconView.swift:125:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/MainWindowController.swift:390:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/OPML/ExportOPMLWindowController.swift:96:6: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Sidebar/PasteboardFeed.swift:79:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Sidebar/PasteboardFeed.swift:94:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Sidebar/SidebarOutlineDataSource.swift:170:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Sidebar/SidebarViewController+ContextualMenus.swift:236:5: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Timeline/ArticlePasteboardWriter.swift:81:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Timeline/ArticlePasteboardWriter.swift:84:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Timeline/Cell/MultilineTextFieldSizer.swift:230:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Timeline/Cell/TimelineCellLayout.swift:45:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Timeline/Cell/TimelineCellLayout.swift:65:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Timeline/Cell/TimelineTableCellView.swift:152:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Timeline/TimelineContainerViewController.swift:175:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Timeline/TimelineViewController.swift:1336:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Timeline/TimelineViewController.swift:361:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Timeline/TimelineViewController.swift:535:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/MainWindow/Timeline/TimelineViewController.swift:925:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/Preferences/Accounts/AccountsFeedbinWindowController.swift:108:5: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/Preferences/Accounts/AccountsNewsBlurWindowController.swift:106:5: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/Preferences/Accounts/AccountsReaderAPIWindowController.swift:165:5: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/Preferences/Advanced/AdvancedPreferencesViewController.swift:56:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/Preferences/PreferencesWindowController.swift:150:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Mac/SafariExtension/SafariExtensionHandler.swift:64:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:233:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:293:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:296:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:299:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:302:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:305:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:127:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:132:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:183:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:254:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:282:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:285:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Extensions/ArticleUtilities.swift:166:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Extensions/ArticleUtilities.swift:169:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Extensions/ArticleUtilities.swift:172:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Extensions/ArticleUtilities.swift:175:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Favicons/FaviconURLFinder.swift:58:5: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Favicons/SingleFaviconDownloader.swift:127:4: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Shared/Images/AuthorAvatarDownloader.swift:46:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /SyncClients/Feedbin/Sources/Feedbin/FeedbinEntry.swift:33:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Widget/Widget Views/StarredWidget.swift:23:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Widget/Widget Views/TodayWidget.swift:23:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /Widget/Widget Views/UnreadWidget.swift:23:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /iOS/AppDefaults.swift:349:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /iOS/IconView.swift:22:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /iOS/IconView.swift:99:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /iOS/MainFeed/MainFeedViewController.swift:105:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /iOS/MainTimeline/Cell/MainTimelineCellData.swift:48:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /iOS/MainTimeline/Cell/MultilineUILabelSizer.swift:168:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /iOS/MainTimeline/MainTimelineTitleView.swift:27:4: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in NetNewsWire: /iOS/SceneCoordinator.swift:1269:3: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Private/TokenHelper.swift:143:13: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Private/TokenHelper.swift:74:9: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Public/ServerPodcastManager.swift:367:79: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Public/ServerPodcastManager.swift:372:77: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Public/Sync/SyncTask.swift:279:17: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Public/Sync/UpNextSyncTask.swift:191:21: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Public/Sync/UpNextSyncTask.swift:200:21: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Public/URLResponse+HttpHelpers.swift:61:9: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Public/URLResponse+HttpHelpers.swift:65:9: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/FileRotating.swift:42:81: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/PersistentTextWriting.swift:31:13: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /Pocket Casts Watch App Extension/WatchSyncManager.swift:130:13: warning: Statement Position Violation: 'catch' should be on the same line, one space after the closing brace of the previous block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /podcasts/AppDelelgate+SiriShortcuts.swift:55:13: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: This PR introduced a violation in PocketCasts: /podcasts/AuthenticationHelper.swift:15:9: warning: Statement Position Violation: 'else' should be on the same line, one space after the closing brace of the previous 'if' block (statement_position)
:warning: Danger found 318 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 118.
305 Messages
:book: Linting Aerial with this PR took 1.18s vs 1.17s on main (0% slower)
:book: Linting Alamofire with this PR took 1.62s vs 1.61s on main (0% slower)
:book: Linting Brave with this PR took 9.27s vs 9.25s on main (0% slower)
:book: Linting DuckDuckGo with this PR took 5.08s vs 5.06s on main (0% slower)
:book: Linting Firefox with this PR took 11.04s vs 11.07s on main (0% faster)
:book: Linting Kickstarter with this PR took 11.12s vs 11.14s on main (0% faster)
:book: Linting Moya with this PR took 0.65s vs 0.62s on main (4% slower)
:book: Linting NetNewsWire with this PR took 3.3s vs 3.3s on main (0% slower)
:book: Linting Nimble with this PR took 0.9s vs 0.89s on main (1% slower)
:book: Linting PocketCasts with this PR took 8.95s vs 8.9s on main (0% slower)
:book: Linting Quick with this PR took 0.4s vs 0.4s on main (0% slower)
:book: Linting Realm with this PR took 5.78s vs 5.82s on main (0% faster)
:book: Linting Sourcery with this PR took 2.89s vs 2.87s on main (0% slower)
:book: Linting Swift with this PR took 5.42s vs 5.4s on main (0% slower)
:book: Linting VLC with this PR took 1.6s vs 1.58s on main (1% slower)
:book: Linting Wire with this PR took 20.12s vs 20.05s on main (0% slower)
:book: Linting WordPress with this PR took 13.52s vs 13.42s on main (0% slower)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/Account.swift:1478:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/Account.swift:1481:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/Account.swift:254:5: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/FeedbinAccountDelegate.swift:1143:7: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/FeedbinAccountDelegate.swift:697:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/FeedbinAccountDelegate.swift:944:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/NewsBlurAccountDelegate+Internal.swift:115:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountDelegates/NewsBlurAccountDelegate+Internal.swift:416:7: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountManager.swift:107:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountManager.swift:162:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountManager.swift:450:13: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/AccountManager.swift:535:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/Feed.swift:117:5: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/Feed.swift:47:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/Feed.swift:98:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Sources/Account/Feedly/Operations/FeedlyAddNewFeedOperation.swift:140:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Tests/AccountTests/TestAccountManager.swift:45:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Account/Tests/AccountTests/TestAccountManager.swift:48:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Articles/Sources/Articles/Article.swift:49:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Articles/Sources/Articles/Author.swift:30:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Articles/Sources/Articles/Author.swift:50:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Articles/Sources/Articles/Author.swift:79:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/FeedFinder.swift:109:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/FeedFinder.swift:120:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/FeedFinder.swift:124:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/FeedFinder.swift:87:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/FeedSpecifier.swift:76:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /FeedFinder/Sources/FeedFinder/HTMLFeedFinder.swift:53:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/AppDefaults.swift:113:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/AppDefaults.swift:461:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/AppDelegate.swift:126:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/AppDelegate.swift:154:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/AppDelegate.swift:188:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/AppDelegate.swift:624:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/Inspector/InspectorWindowController.swift:70:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/Inspector/InspectorWindowController.swift:83:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/Inspector/NothingInspectorViewController.swift:42:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Detail/DetailContainerView.swift:70:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Detail/DetailStatusBarView.swift:28:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Detail/DetailStatusBarView.swift:71:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/IconView.swift:125:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/MainWindowController.swift:390:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/OPML/ExportOPMLWindowController.swift:96:6: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Sidebar/PasteboardFeed.swift:79:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Sidebar/PasteboardFeed.swift:94:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Sidebar/SidebarOutlineDataSource.swift:170:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Sidebar/SidebarViewController+ContextualMenus.swift:236:5: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Timeline/ArticlePasteboardWriter.swift:81:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Timeline/ArticlePasteboardWriter.swift:84:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Timeline/Cell/MultilineTextFieldSizer.swift:230:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Timeline/Cell/TimelineCellLayout.swift:45:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Timeline/Cell/TimelineCellLayout.swift:65:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Timeline/Cell/TimelineTableCellView.swift:152:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Timeline/TimelineContainerViewController.swift:175:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Timeline/TimelineViewController.swift:1336:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Timeline/TimelineViewController.swift:361:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Timeline/TimelineViewController.swift:535:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/MainWindow/Timeline/TimelineViewController.swift:925:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/Preferences/Accounts/AccountsFeedbinWindowController.swift:108:5: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/Preferences/Accounts/AccountsNewsBlurWindowController.swift:106:5: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/Preferences/Accounts/AccountsReaderAPIWindowController.swift:165:5: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/Preferences/Advanced/AdvancedPreferencesViewController.swift:56:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/Preferences/PreferencesWindowController.swift:150:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Mac/SafariExtension/SafariExtensionHandler.swift:64:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:233:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:293:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:296:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:299:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:302:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Article Rendering/ArticleRenderer.swift:305:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:127:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:132:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:183:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:254:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:282:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Commands/DeleteCommand.swift:285:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Extensions/ArticleUtilities.swift:166:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Extensions/ArticleUtilities.swift:169:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Extensions/ArticleUtilities.swift:172:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Extensions/ArticleUtilities.swift:175:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Favicons/FaviconURLFinder.swift:58:5: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Favicons/SingleFaviconDownloader.swift:127:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Shared/Images/AuthorAvatarDownloader.swift:46:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /SyncClients/Feedbin/Sources/Feedbin/FeedbinEntry.swift:33:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Widget/Widget Views/StarredWidget.swift:23:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Widget/Widget Views/TodayWidget.swift:23:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /Widget/Widget Views/UnreadWidget.swift:23:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /iOS/AppDefaults.swift:349:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /iOS/IconView.swift:22:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /iOS/IconView.swift:99:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /iOS/MainFeed/MainFeedViewController.swift:105:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /iOS/MainTimeline/Cell/MainTimelineCellData.swift:48:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /iOS/MainTimeline/Cell/MultilineUILabelSizer.swift:168:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /iOS/MainTimeline/MainTimelineTitleView.swift:27:4: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in NetNewsWire: /iOS/SceneCoordinator.swift:1269:3: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Private/TokenHelper.swift:143:13: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Private/TokenHelper.swift:74:9: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Public/ServerPodcastManager.swift:367:79: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /Modules/Server/Sources/PocketCastsServer/Public/ServerPodcastManager.swift:372:77: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/FileRotating.swift:42:81: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Logging/PersistentTextWriting.swift:31:13: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /Pocket Casts Watch App Extension/WatchSyncManager.swift:130:13: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/AuthenticationHelper.swift:15:9: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/Bookmarks/List/BookmarksListView.swift:50:9: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/End of Year/StoriesModel.swift:84:17: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:10:62: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:11:66: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:12:60: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:13:61: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:14:62: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:16:60: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:17:61: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:18:62: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:19:62: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:20:64: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:21:60: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:22:60: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:23:62: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:24:62: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:book: This PR fixed a violation in PocketCasts: /podcasts/FileTypeUtil.swift:25:64: warning: Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration (statement_position)
:warning: Danger found 305 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 137.

Generated by :no_entry_sign: Danger

SwiftLintBot avatar May 02 '23 04:05 SwiftLintBot

Much appreciated! @SimplyDanny what are next steps for us?

lhunath avatar Jun 02 '23 22:06 lhunath

@enebin: Is there an interest on your side to continue working on this PR?

SimplyDanny avatar Dec 02 '23 19:12 SimplyDanny

@enebin: Is there an interest on your side to continue working on this PR?

@SimplyDanny I apologize. I had completely forgotten about this PR 😅 Thank you for reminding me. Could you possibly give me a bit more time? I will come back with a review and response to this PR as soon as possible.

enebin avatar Dec 03 '23 05:12 enebin

Could you possibly give me a bit more time? I will come back with a review and response to this PR as soon as possible.

Sure. Take your time. I only wanted to make sure this PR is not abandoned.

SimplyDanny avatar Dec 03 '23 07:12 SimplyDanny

I apologize for the delay. I've been going through a busy period personally, so even a simple request took too long. I've now requested a review again @SimplyDanny

enebin avatar Jan 04 '24 06:01 enebin