SwiftLint icon indicating copy to clipboard operation
SwiftLint copied to clipboard
verified publisher icon realm

Remove the need for rules_xcodeproj dependency for downstream consumers

Open thii opened this issue 2 years ago • 3 comments

This was needed because the xcodeproj target was declared in the same BUILD file with the @SwiftLint//:swiftlint target, so when users run bazel run @SwiftLint//:swiftlint, bazel would try to load rules_xcodeproj. rules_xcodeproj 1.0 allows us to specify the location of the generated Xcode project, so we don't need this target in the top-level BUILD file anymore.

This only fixes for non-bzlmod case now.

Fixes https://github.com/realm/SwiftLint/issues/4737

thii avatar Feb 17 '23 11:02 thii

1 Message
:book: Skipping OSSCheck because SwiftLint hasn't changed compared to 'main'

Generated by :no_entry_sign: Danger

SwiftLintBot avatar Feb 17 '23 11:02 SwiftLintBot

I'm happy to merge this now but the PR is marked as draft. Did you still want to work on this before I merge?

jpsim avatar Feb 17 '23 12:02 jpsim

It should be ready now. I was waiting for CI to be green before marking it as ready to reduce notification noises.

thii avatar Feb 17 '23 12:02 thii

Merged in https://github.com/realm/SwiftLint/pull/5112, thanks for your contribution!

jpsim avatar Jul 09 '23 13:07 jpsim