SwiftLint icon indicating copy to clipboard operation
SwiftLint copied to clipboard

Update SwiftSyntax (2023-01-16)

Open jpsim opened this issue 2 years ago • 3 comments

Probably can't merge until a new release of SwiftSyntax is cut to avoid the SwiftPM dependency resolution issues, but there have been a lot of breaking changes in the weeks since the last release that I didn't want to get too far behind.

I'm also hoping that the memory corruption fix in https://github.com/apple/swift-syntax/pull/1190 helps with the tsan crashes I've been seeing occasionally on CI.

jpsim avatar Jan 16 '23 21:01 jpsim

823 Warnings
:warning: Big PR
:warning: If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
:warning: This PR may need tests.
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:334:12: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Alamofire: /Source/AuthenticationInterceptor.swift:228:13: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Alamofire: /Source/Combine.swift:316:17: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Alamofire: /Source/Combine.swift:466:17: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Alamofire: /Source/Combine.swift:95:17: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Alamofire: /Source/MultipartUpload.swift:32:18: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:117:13: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Alamofire: /Source/Request.swift:1092:13: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Alamofire: /Source/Request.swift:1265:5: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Alamofire: /Source/Request.swift:129:17: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Alamofire: /Source/Request.swift:1550:13: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Alamofire: /Source/Request.swift:193:17: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /App/BraveWidgets/FavoritesWidget.swift:90:32: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /App/BraveWidgets/FavoritesWidget.swift:91:31: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /App/BraveWidgets/FavoritesWidget.swift:92:31: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /App/BraveWidgets/FavoritesWidget.swift:93:36: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /App/BraveWidgets/StatsWidget.swift:52:36: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Extensions/Rewards/BraveLedgerExtensions.swift:102:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Extensions/Rewards/BraveLedgerExtensions.swift:136:21: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/Authenticator.swift:101:33: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/BrowserViewController/BrowserViewController+Menu.swift:263:41: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/BrowserViewController/BrowserViewController+Wallet.swift:264:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/BrowserViewController/BrowserViewController+Wallet.swift:274:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/BrowserViewController/BrowserViewController+Wallet.swift:502:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/Certificate Viewer/CertificateViewController.swift:116:11: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/FaviconHandler.swift:26:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PageData.swift:32:23: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PageData.swift:42:23: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PageData.swift:68:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PageData.swift:73:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PageZoom/PageZoomView.swift:75:48: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/Playlist/Controllers/PlaylistMoveFolderView.swift:104:5: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/Playlist/Controllers/PlaylistMoveFolderView.swift:98:5: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/Playlist/Controllers/PlaylistNewFolderView.swift:121:5: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/Playlist/PlaylistSharedFolder.swift:143:5: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/AllVPNAlertsView.swift:13:42: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/AllVPNAlertsView.swift:14:49: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/AllVPNAlertsView.swift:16:42: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/AllVPNAlertsView.swift:24:15: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/NotificationCalloutView.swift:15:49: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/NotificationCalloutView.swift:16:42: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/PrivacyHubAllTimeSection.swift:14:42: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/PrivacyHubAllTimeSection.swift:15:49: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/PrivacyHubAllTimeSection.swift:16:41: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/PrivacyHubVPNAlertsSection.swift:13:41: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/PrivacyReportAllTimeListsView.swift:12:47: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/PrivacyReportAllTimeListsView.swift:13:40: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/PrivacyReportLabels.swift:24:42: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/PrivacyReportLabels.swift:42:42: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/PrivacyReportsView.swift:12:53: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/VPNAlertCell.swift:12:42: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/PrivacyHub/VPNAlertCell.swift:13:49: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/Tabs/RecentlyClosedTabs/RecentlyClosedTabsView.swift:15:53: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/ToolbarVisibilityViewModel.swift:43:12: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/Toolbars/BottomToolbar/Menu/MenuViewController.swift:14:39: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/Toolbars/BottomToolbar/Menu/MenuViewController.swift:58:31: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/Toolbars/BottomToolbar/Menu/PlaylistMenuButton.swift:14:39: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Browser/Toolbars/BottomToolbar/Menu/PlaylistMenuButton.swift:17:3: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Popup/CookieNotificationBlockingConsentView.swift:22:53: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Settings/AdblockDebugMenuTableViewController.swift:56:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Settings/BraveCoreDebugSwitchesView.swift:114:53: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Settings/BraveCoreDebugSwitchesView.swift:60:53: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Settings/BraveShieldsAndPrivacySettingsController.swift:458:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/Settings/Clearables.swift:16:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/SolanaProviderScriptHandler.swift:143:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/SolanaProviderScriptHandler.swift:163:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/SolanaProviderScriptHandler.swift:187:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/SolanaProviderScriptHandler.swift:211:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/SolanaProviderScriptHandler.swift:244:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/SolanaProviderScriptHandler.swift:266:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/Frontend/UserContent/UserScripts/Scripts_Dynamic/ScriptHandlers/Paged/SolanaProviderScriptHandler.swift:319:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/ContentBlocker/ContentBlockerManager.swift:317:21: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/ContentBlocker/TrackingProtectionPageStats.swift:50:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:100:24: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:118:24: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:172:21: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:223:21: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:240:21: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:254:21: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:261:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:299:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:309:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:333:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:357:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:365:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:387:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:38:23: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:43:23: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:503:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:51:23: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:71:23: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/FilterListResourceDownloader.swift:90:23: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/ShieldStats/Adblock/AdBlockStats.swift:41:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/ShieldStats/Adblock/AdBlockStats.swift:46:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/ShieldStats/Adblock/AdBlockStats.swift:65:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/ShieldStats/Adblock/CachedAdBlockEngine.swift:120:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/ShieldStats/Adblock/CachedAdBlockEngine.swift:43:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/ShieldStats/Adblock/CachedAdBlockEngine.swift:54:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Client/WebFilters/ShieldStats/Adblock/CachedAdBlockEngine.swift:89:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Composer/FeedDataSource+RSS.swift:103:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Composer/FeedDataSource+RSS.swift:85:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Composer/FeedDataSource.swift:288:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Composer/FeedDataSource.swift:459:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Composer/FeedDataSource.swift:705:14: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Customize/ChannelLabel.swift:15:40: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Customize/ChannelLabel.swift:17:24: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Customize/FollowToggle.swift:24:41: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Customize/RSSFeedLabel.swift:14:40: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Customize/RSSFeedLabel.swift:16:24: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Customize/SourceLabel.swift:16:39: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Customize/SourceLabel.swift:60:40: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveNews/Customize/SourceLabel.swift:62:24: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveTalk/BraveTalkJitsiCoordinator.swift:13:19: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveUI/SwiftUI/AccessibilityEmbedInScrollViewViewModifier.swift:34:40: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveUI/SwiftUI/AccessibilityEmbedInScrollViewViewModifier.swift:37:16: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveUI/SwiftUI/FilterableViewModifier.swift:60:23: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveUI/SwiftUI/ListInitialOffsetWorkaround.swift:33:23: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: This PR introduced a violation in Brave: /Sources/BraveUI/SwiftUI/ResetListStyleModifier.swift:10:40: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
:warning: Danger found 823 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 121.
19 Messages
:book: Linting Aerial with this PR took 1.08s vs 1.1s on main (1% faster)
:book: Linting Alamofire with this PR took 1.36s vs 1.41s on main (3% faster)
:book: Linting Brave with this PR took 7.3s vs 7.54s on main (3% faster)
:book: Linting DuckDuckGo with this PR took 2.95s vs 3.02s on main (2% faster)
:book: Linting Firefox with this PR took 9.24s vs 9.51s on main (2% faster)
:book: Linting Kickstarter with this PR took 9.97s vs 10.33s on main (3% faster)
:book: Linting Moya with this PR took 0.53s vs 0.57s on main (7% faster)
:book: Linting NetNewsWire with this PR took 3.2s vs 3.25s on main (1% faster)
:book: Linting Nimble with this PR took 0.59s vs 0.64s on main (7% faster)
:book: Linting PocketCasts with this PR took 7.19s vs 7.64s on main (5% faster)
:book: Linting Quick with this PR took 0.24s vs 0.24s on main (0% slower)
:book: Linting Realm with this PR took 11.55s vs 12.02s on main (3% faster)
:book: Linting SourceKitten with this PR took 0.43s vs 0.44s on main (2% faster)
:book: Linting Sourcery with this PR took 2.21s vs 2.33s on main (5% faster)
:book: Linting Swift with this PR took 4.63s vs 4.76s on main (2% faster)
:book: Linting VLC with this PR took 1.37s vs 1.41s on main (2% faster)
:book: Linting Wire with this PR took 8.51s vs 9.15s on main (6% faster)
:book: Linting WordPress with this PR took 11.16s vs 11.4s on main (2% faster)
:book: This PR fixed a violation in Realm: /Realm/ObjectServerTests/SwiftUIServerTests.swift:31:1: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)

Here's an example of your CHANGELOG entry:

* Update SwiftSyntax (2023-01-16).  
  [jpsim](https://github.com/jpsim)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by :no_entry_sign: Danger

SwiftLintBot avatar Jan 16 '23 22:01 SwiftLintBot

Linting the Brave & Wordpress projects causes SwiftLint to crash with this PR (SIGTRAP). I'll look into that.

jpsim avatar Jan 16 '23 22:01 jpsim

All other OSSCheck reports appear to fix false positives/negatives.

jpsim avatar Jan 16 '23 22:01 jpsim