SwiftLint icon indicating copy to clipboard operation
SwiftLint copied to clipboard

Rewrite `fatal_error_message` rule with SwiftSyntax

Open marcelofabri opened this issue 2 years ago • 1 comments

marcelofabri avatar Sep 20 '22 11:09 marcelofabri

22 Warnings
:warning: If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
:warning: This PR introduced a violation in Swift: /validation-test/IDE/crashers_2_fixed/issue-56849.swift:11:51: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/crashers_2_fixed/issue-56849.swift:21:9: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/crashers_2_fixed/issue-57054.swift:13:47: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/crashers_2_fixed/issue-57054.swift:14:70: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/crashers_2_fixed/issue-57054.swift:6:39: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/crashers_2_fixed/issue-57054.swift:7:90: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/crashers_2_fixed/rdar76686564.swift:13:59: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/crashers_2_fixed/rdar76686564.swift:17:3: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/crashers_fixed/issue-57321.swift:31:68: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/issues_fixed/issue-57041.swift:12:82: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/issues_fixed/issue-57041.swift:20:5: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/issues_fixed/issue-57041.swift:25:46: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/issues_fixed/issue-57041.swift:26:97: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/issues_fixed/issue-57041.swift:27:96: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/issues_fixed/issue-57041.swift:28:101: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/issues_fixed/issue-57041.swift:39:5: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/issues_fixed/issue-57041.swift:52:5: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/issues_fixed/issue-57041.swift:59:5: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/stress_tester_issues_fixed/issue-57058.swift:12:38: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/stress_tester_issues_fixed/issue-57058.swift:13:89: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
:warning: This PR introduced a violation in Swift: /validation-test/IDE/stress_tester_issues_fixed/issue-57058.swift:21:50: warning: Fatal Error Message Violation: A fatalError call should have a message. (fatal_error_message)
13 Messages
:book: Linting Aerial with this PR took 0.14s vs 0.23s on main (39% faster)
:book: Linting Alamofire with this PR took 0.21s vs 0.29s on main (27% faster)
:book: Linting DuckDuckGo with this PR took 0.34s vs 0.63s on main (46% faster)
:book: Linting Firefox with this PR took 0.7s vs 1.4s on main (50% faster)
:book: Linting Kickstarter with this PR took 1.02s vs 1.93s on main (47% faster)
:book: Linting Moya with this PR took 0.16s vs 0.16s on main (0% slower)
:book: Linting Nimble with this PR took 0.13s vs 0.16s on main (18% faster)
:book: Linting Quick with this PR took 0.07s vs 0.08s on main (12% faster)
:book: Linting Realm with this PR took 1.39s vs 1.13s on main (23% slower)
:book: Linting SourceKitten with this PR took 0.08s vs 0.13s on main (38% faster)
:book: Linting Sourcery with this PR took 0.35s vs 0.44s on main (20% faster)
:book: Linting Swift with this PR took 0.8s vs 1.0s on main (19% faster)
:book: Linting WordPress with this PR took 1.04s vs 2.35s on main (55% faster)

Here's an example of your CHANGELOG entry:

* Rewrite `fatal_error_message` rule with SwiftSyntax.  
  [marcelofabri](https://github.com/marcelofabri)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by :no_entry_sign: Danger

SwiftLintBot avatar Sep 20 '22 11:09 SwiftLintBot