SwiftLint icon indicating copy to clipboard operation
SwiftLint copied to clipboard

Rewrite `private_outlet` with SwiftSyntax

Open jpsim opened this issue 2 years ago • 2 comments

jpsim avatar Sep 19 '22 19:09 jpsim

2 Warnings
:warning: If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
:warning: This PR may need tests.
12 Messages
:book: Linting Aerial with this PR took 0.13s vs 0.23s on main (43% faster)
:book: Linting Alamofire with this PR took 0.09s vs 0.3s on main (70% faster)
:book: Linting Firefox with this PR took 0.35s vs 1.44s on main (75% faster)
:book: Linting Kickstarter with this PR took 0.48s vs 1.98s on main (75% faster)
:book: Linting Moya with this PR took 0.13s vs 0.16s on main (18% faster)
:book: Linting Nimble with this PR took 0.08s vs 0.16s on main (50% faster)
:book: Linting Quick with this PR took 0.06s vs 0.08s on main (25% faster)
:book: Linting Realm with this PR took 0.41s vs 1.12s on main (63% faster)
:book: Linting SourceKitten with this PR took 0.08s vs 0.13s on main (38% faster)
:book: Linting Sourcery with this PR took 0.18s vs 0.45s on main (60% faster)
:book: Linting Swift with this PR took 0.66s vs 0.91s on main (27% faster)
:book: Linting WordPress with this PR took 0.54s vs 2.33s on main (76% faster)

Here's an example of your CHANGELOG entry:

* Rewrite `private_outlet` with SwiftSyntax.  
  [jpsim](https://github.com/jpsim)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by :no_entry_sign: Danger

SwiftLintBot avatar Sep 19 '22 22:09 SwiftLintBot

All the fixed violations in the OSSCheck report need to be addressed before I can merge this.

jpsim avatar Sep 20 '22 20:09 jpsim

Will close & re-open to try to kick off CI. Neither Azure Pipelines nor Buildkite jobs are getting kicked off and githubstatus.com doesn't show any known issues with webhooks.

jpsim avatar Oct 05 '22 13:10 jpsim

There we go:

Webhooks is experiencing degraded performance. We are continuing to investigate.

https://www.githubstatus.com/incidents/smn1qtqvbsb6

Will wait a bit for it to resolve.

jpsim avatar Oct 05 '22 13:10 jpsim