SwiftLint icon indicating copy to clipboard operation
SwiftLint copied to clipboard

Published 20 hours ago • verified publisher icon realm

Rewrite `for_where`, adding `allow_for_as_filter` config

Open marcelofabri opened this issue 2 years ago • 2 comments

Fixes #4040

marcelofabri avatar Sep 04 '22 06:09 marcelofabri

1 Warning
:warning: This PR may need tests.

Generated by :no_entry_sign: Danger

SwiftLintBot avatar Sep 04 '22 06:09 SwiftLintBot

What do you think about https://github.com/JohnCoates/Aerial/blob/97068951d2c67a56d42f705d405bd0578e45a672/Aerial/Source/Models/ManifestLoader.swift#L955:25 which was flagged by OSSCheck?

jpsim avatar Sep 04 '22 20:09 jpsim

What do you think about https://github.com/JohnCoates/Aerial/blob/97068951d2c67a56d42f705d405bd0578e45a672/Aerial/Source/Models/ManifestLoader.swift#L955:25 which was flagged by OSSCheck?

I could go either way honestly. I think complex where conditions are not great, so maybe not throwing a violation here and leaving it for the developer's judgement is better?

marcelofabri avatar Oct 16 '22 06:10 marcelofabri