SwiftLint icon indicating copy to clipboard operation
SwiftLint copied to clipboard

Published 20 hours ago • verified publisher icon realm

Add Type ACL Order Rule

Open jd014 opened this issue 2 years ago • 6 comments

Overview: This PR adds a new rule to enforce access control level (ACL) ordering within types. This rule expands upon the type contents order rule by using the same logic to separate a type into components. It then validates the ACL ordering of all instances for each component type. Closes #2410 and #3672.

Discussion:

  1. Separate rule instead of an added configuration option on type_contents_order A standalone rule allows for more configuration capabilities and no rule coupling. You could use this rule without even implementing type_contents_order and it would function properly, which seems to be a good enough argument to have a separate rule.
  2. Configuration Options I chose to keep it simple and just add an ACL order configuration option for now. If there is a need for further configuration such as content types to include/exclude/group then it can be extended to include this.
  3. Disabled by Default This style rule is very opinionated and would trigger an obscene amount of warnings for most projects.
  4. Autocorrect Autocorrect is not implemented in this PR. I'm not confident there is a good way to automate this without impacting other stylistic elements like spacing and type ordering.
  5. Rule Naming type_acl_order is succinct and very meaningful if you know what ACL means, however I wouldn't qualify ACL as a common knowledge acronym for swift developers. However, other rules use ACL and I think consistency is important. I would also be open to including contents in the name such as type_contents_acl_order, but I'm not sure how much value it adds.

jd014 avatar Apr 04 '22 01:04 jd014

8136 Warnings
:warning: Big PR
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:215:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:282:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:153:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:203:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:213:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:229:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:366:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:408:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:446:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:461:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:491:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:498:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:505:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:539:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:555:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:575:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:594:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:628:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:645:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:683:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:771:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:117:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:129:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:138:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:231:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:235:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:241:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:286:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:97:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:152:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:169:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:196:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:206:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:25:17: warning: Type ACL Order Violation: A 'fileprivate instanceProperty' should not be declared after a 'private instanceProperty'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:29:5: warning: Type ACL Order Violation: An 'internal instanceProperty' should not be declared after a 'private instanceProperty'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/AsynchronousOperation.swift:52:27: warning: Type ACL Order Violation: An 'open instanceProperty' should not be declared after a 'private instanceProperty'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/AsynchronousOperation.swift:53:27: warning: Type ACL Order Violation: A 'public instanceProperty' should not be declared after a 'private instanceProperty'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/AsynchronousOperation.swift:54:27: warning: Type ACL Order Violation: A 'public instanceProperty' should not be declared after a 'private instanceProperty'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/AsynchronousOperation.swift:82:19: warning: Type ACL Order Violation: An 'open otherMethod' should not be declared after a 'public otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:29:10: warning: Type ACL Order Violation: An 'internal instanceProperty' should not be declared after a 'private instanceProperty'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/HardwareDetection.swift:139:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/HardwareDetection.swift:45:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/HardwareDetection.swift:93:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:590:5: warning: Type ACL Order Violation: An 'internal instanceProperty' should not be declared after a 'private instanceProperty'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:690:5: warning: Type ACL Order Violation: An 'internal instanceProperty' should not be declared after a 'private instanceProperty'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsVideos.swift:195:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsVideos.swift:202:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceList.swift:437:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceList.swift:459:5: warning: Type ACL Order Violation: An 'internal typeMethod' should not be declared after a 'private typeMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:224:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:228:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:232:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:236:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:240:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:244:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:249:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:259:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:282:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:293:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:298:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:389:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:419:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:480:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:525:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/VideoList.swift:539:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/Solar.swift:92:12: warning: Type ACL Order Violation: A 'public subtype' should not be declared after a 'fileprivate subtype'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:111:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:220:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:270:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:290:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:713:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:727:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:753:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LayerManager.swift:102:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LayerManager.swift:125:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LayerManager.swift:133:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LayerManager.swift:142:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LayerManager.swift:157:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LayerManager.swift:167:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LayerManager.swift:184:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoTableSource.swift:13:5: warning: Type ACL Order Violation: An 'internal instanceProperty' should not be declared after a 'private instanceProperty'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/OverlaysViewController.swift:176:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/SidebarViewController.swift:101:5: warning: Type ACL Order Violation: An 'internal otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/Concurrency.swift:611:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/Concurrency.swift:616:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/Concurrency.swift:621:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after a 'private otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:329:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:333:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:339:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:353:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:359:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:371:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:375:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:380:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:384:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:388:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:394:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:406:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:420:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:426:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:430:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:434:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:438:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:442:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:446:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:450:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:454:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:458:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:462:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:466:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:470:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:474:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:478:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:482:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:486:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:490:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:494:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:507:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:511:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:515:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:526:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:530:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:534:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:538:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:542:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:546:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:550:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:562:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:566:12: warning: Type ACL Order Violation: A 'public otherMethod' should not be declared after an 'internal otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:825:10: warning: Type ACL Order Violation: An 'open otherMethod' should not be declared after a 'public otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:833:10: warning: Type ACL Order Violation: An 'open otherMethod' should not be declared after a 'public otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:841:10: warning: Type ACL Order Violation: An 'open otherMethod' should not be declared after a 'public otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:849:10: warning: Type ACL Order Violation: An 'open otherMethod' should not be declared after a 'public otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:857:10: warning: Type ACL Order Violation: An 'open otherMethod' should not be declared after a 'public otherMethod'. (type_acl_order)
:warning: This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:861:10: warning: Type ACL Order Violation: An 'open otherMethod' should not be declared after a 'public otherMethod'. (type_acl_order)
:warning: Danger found 8136 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 136.
12 Messages
:book: Linting Aerial with this PR took 0.99s vs 0.99s on master (0% slower)
:book: Linting Alamofire with this PR took 1.11s vs 1.1s on master (0% slower)
:book: Linting Firefox with this PR took 4.54s vs 4.52s on master (0% slower)
:book: Linting Kickstarter with this PR took 7.63s vs 7.61s on master (0% slower)
:book: Linting Moya with this PR took 0.56s vs 0.56s on master (0% slower)
:book: Linting Nimble with this PR took 0.42s vs 0.42s on master (0% slower)
:book: Linting Quick with this PR took 0.19s vs 0.19s on master (0% slower)
:book: Linting Realm with this PR took 10.0s vs 10.0s on master (0% slower)
:book: Linting SourceKitten with this PR took 0.34s vs 0.33s on master (3% slower)
:book: Linting Sourcery with this PR took 2.06s vs 2.05s on master (0% slower)
:book: Linting Swift with this PR took 3.46s vs 3.46s on master (0% slower)
:book: Linting WordPress with this PR took 8.22s vs 8.19s on master (0% slower)

Generated by :no_entry_sign: Danger

SwiftLintBot avatar Apr 04 '22 04:04 SwiftLintBot

Codecov Report

Merging #3932 (09fa2c5) into master (4aa3895) will increase coverage by 0.10%. The diff coverage is 99.41%.

@@            Coverage Diff             @@
##           master    #3932      +/-   ##
==========================================
+ Coverage   92.46%   92.56%   +0.10%     
==========================================
  Files         448      452       +4     
  Lines       22799    23092     +293     
==========================================
+ Hits        21080    21376     +296     
+ Misses       1719     1716       -3
Impacted Files Coverage Δ
...RuleConfigurations/TypeACLOrderConfiguration.swift 88.23% <88.23%> (ø)
...iftLintFramework/Extensions/String+SwiftLint.swift 92.00% <100.00%> (+2.00%) :arrow_up:
...onfigurations/TypeContentsOrderConfiguration.swift 97.56% <100.00%> (+3.44%) :arrow_up:
...ftLintFramework/Rules/Style/TypeACLOrderRule.swift 100.00% <100.00%> (ø)
...amework/Rules/Style/TypeACLOrderRuleExamples.swift 100.00% <100.00%> (ø)
...tFramework/Rules/Style/TypeContentsOrderRule.swift 100.00% <100.00%> (+8.04%) :arrow_up:
...wiftLintFrameworkTests/TypeACLOrderRuleTests.swift 100.00% <100.00%> (ø)
Source/SwiftLintFramework/Models/Linter.swift 82.77% <0.00%> (-1.67%) :arrow_down:
...tFrameworkTests/AutomaticRuleTests.generated.swift 100.00% <0.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar Apr 04 '22 04:04 codecov-commenter

Hey @jpsim, @SimplyDanny, @marcelofabri. Finally got around to updating this PR. Could I get some feedback when you get a chance? Thanks.

jd014 avatar Jul 24 '22 19:07 jd014

@jd014 Any plans to resolve the conflicts on this?

sethdeckard avatar Aug 18 '23 12:08 sethdeckard

@sethdeckard if any maintainers of this project have an interest in reviewing and potentially merging this PR, I can put aside some time to fix the conflicts. I had this PR up to date for awhile, but the core team was not prioritizing rule requests. I am not sure if that has changed.

jd014 avatar Aug 18 '23 18:08 jd014

@sethdeckard if any maintainers of this project have an interest in reviewing and potentially merging this PR, I can put aside some time to fix the conflicts. I had this PR up to date for awhile, but the core team was not prioritizing rule requests. I am not sure if that has changed.

I've had PRs merged fairly regularly (https://github.com/realm/SwiftLint/pulls?q=is%3Amerged+is%3Apr+author%3Amildm8nnered+) including new rules ...

mildm8nnered avatar Aug 19 '23 11:08 mildm8nnered