SwiftLint icon indicating copy to clipboard operation
SwiftLint copied to clipboard

Add Directory name no space opt-in rule

Open timcmiller opened this issue 4 years ago • 6 comments

#3012

This PR adds a new opt-in rule directory-name-no-space. When passing in the parentDirectory to the rule it ensure that no directory in the path contains a space. This is a sister rule to already present FileNameNoSpaceRule.swift.

Does not trigger

DirectoryName
Directory_Name
Directory-Name

Does Trigger

Directory Name

timcmiller avatar Feb 16 '21 23:02 timcmiller

338 Warnings
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/First time setup/WelcomeViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/First time setup/CacheSetupViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/First time setup/RecapViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/First time setup/NextViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Infos panels/InfoViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/First time setup/FirstSetupWindowController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Infos panels/CreditsViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Infos panels/HelpViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/First time setup/VideoFormatViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/First time setup/TimeSetupViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/DisplaysViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/UpdatesViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/FiltersViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/BrightnessViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/OverlaysViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/CacheViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/SourcesViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/AdvancedViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Aerial: /Resources/MainUI/Settings panels/TimeViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Alamofire: /watchOS Example/watchOS Example WatchKit Extension/Networking.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Alamofire: /watchOS Example/watchOS Example WatchKit Extension/HostingController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Alamofire: /watchOS Example/watchOS Example WatchKit Extension/ContentView.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Alamofire: /watchOS Example/watchOS Example WatchKit Extension/ExtensionDelegate.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Firefox: /Client/Frontend/Login Management/LoginListDataSourceHelper.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Firefox: /Client/Frontend/Login Management/BreachAlertsClient.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Firefox: /Client/Frontend/Login Management/NoLoginsView.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Firefox: /Client/Frontend/Login Management/LoginListTableViewCell.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Firefox: /Client/Frontend/Login Management/LoginListViewModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Firefox: /Client/Frontend/Login Management/LoginDetailTableViewCell.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Firefox: /Client/Frontend/Login Management/LoginListSelectionHelper.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Firefox: /Client/Frontend/Login Management/LoginDataSource.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Firefox: /Client/Frontend/Login Management/LoginListViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Firefox: /Client/Frontend/Login Management/BreachAlertsDetailView.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Firefox: /Client/Frontend/Login Management/BreachAlertsManager.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Quick: /Quick Templates/Quick Spec Class.xctemplate/Swift/FILEBASENAME.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Quick: /Quick Templates/Quick Configuration Class.xctemplate/Swift/FILEBASENAME.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Realm: /plugin/Templates/file_templates/Realm Model Object.xctemplate/Swift/FILEBASENAME.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Realm: /examples/installation/watchos/swift/CocoaPodsExample/CocoaPodsExample WatchKit Extension/InterfaceController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Realm: /examples/installation/watchos/swift/XCFrameworkExample/XCFrameworkExample WatchKit Extension/InterfaceController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Realm: /examples/installation/watchos/swift/DynamicExample/DynamicExample WatchKit Extension/InterfaceController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Realm: /examples/installation/watchos/swift/CarthageExample/CarthageExample WatchKit Extension/InterfaceController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/App/Networking/NetworkLogger.swift:13:5: warning: Inclusive Language Violation: Declaration init(whitelist:blacklist:) contains the term "blacklist" which is not considered inclusive. (inclusive_language)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/App/Views/Text Fields/CursorView.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/App/Views/Button Subclasses/Button.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/App/Views/Text Fields/TextField.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Sale Artwork Details/WhitespaceGobbler.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Sale Artwork Details/SaleArtworkZoomViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Sale Artwork Details/ImageTiledDataSource.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Auction Listings/WebViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Auction Listings/TableCollectionViewCell.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Auction Listings/ListingsCountdownManager.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Auction Listings/MasonryCollectionViewCell.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/AdminCCBypassNetworkModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ConfirmYourBidEnterYourEmailViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Auction Listings/ListingsViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/FulfillmentNavigationController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ConfirmYourBidPasswordViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/SwipeCreditCardViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/KeypadView.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/BidDetailsPreviewView.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/RegistrationPasswordViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Auction Listings/ListingsViewModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Sale Artwork Details/SaleArtworkDetailsViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/RegistrationPasswordViewModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/Models/NewUser.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/KeypadContainerView.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/KeypadViewModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/Models/BidDetails.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/RegistrationPostalZipViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/StripeManager.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/Models/RegistrationCoordinator.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/YourBiddingDetailsViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/PlaceBidViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ConfirmYourBidViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/PlaceBidNetworkModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ManualCreditCardInputViewModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/FulfillmentContainerViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/LoadingViewModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/RegistrationMobileViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/GenericFormValidationViewModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ConfirmYourBidPINViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/RegisterViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/ConfirmYourBidArtsyLoginViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/RegistrationEmailViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/BidderNetworkModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/BidCheckingNetworkModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/Bid Fulfillment/LoadingViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/Extensions/Colors and Styles/WPStyleGuide+FilterTabBar.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/Extensions/Colors and Styles/WPStyleGuide+Aztec.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/Extensions/Colors and Styles/UIColor+Notice.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/Extensions/Colors and Styles/UIColor+MurielColorsObjC.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/Extensions/Colors and Styles/WPStyleGuide+Gridicon.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/Extensions/Colors and Styles/WPStyleGuide+Search.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/Extensions/Colors and Styles/MurielColor.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/Extensions/Colors and Styles/UIColor+MurielColors.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderInterestsCollectionViewCell.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/Extensions/Colors and Styles/WPStyleGuide+ApplicationStyles.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderInterestsStyleGuide.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderInterestsDataSource.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Tags View/DynamicHeightCollectionView.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Tags View/TopicsCollectionView.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderInterestsCollectionViewFlowLayout.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Tags View/ReaderTopicCollectionViewCoordinator.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Tab Navigation/ReaderTabItem.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Tab Navigation/ReaderTabViewController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Tab Navigation/WPTabBarController+ReaderTabNavigation.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Tab Navigation/ReaderTabItemsStore.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Tab Navigation/ReaderTabView.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Tab Navigation/ReaderTabViewModel.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Post/Prepublishing Nudge/Blog+Title.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Post/Prepublishing Nudge/PasswordAlertController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Post/Prepublishing Nudge/PrepublishingNavigationController.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Post/Prepublishing Nudge/PrepublishingHeaderView.swift:1:1: warning: Directory Name No Space Violation: Directory names should not contain any whitespace. (directory_name_no_space)
:warning: Danger found 338 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 115.
13 Messages
:book: Linting Aerial with this PR took 2.06s vs 1.99s on master (3% slower)
:book: Linting Alamofire with this PR took 2.86s vs 2.83s on master (1% slower)
:book: Linting Firefox with this PR took 9.76s vs 9.76s on master (0% slower)
:book: Linting Kickstarter with this PR took 15.4s vs 15.47s on master (0% faster)
:book: Linting Moya with this PR took 1.46s vs 1.4s on master (4% slower)
:book: Linting Nimble with this PR took 1.29s vs 1.29s on master (0% slower)
:book: Linting Quick with this PR took 0.63s vs 0.62s on master (1% slower)
:book: Linting Realm with this PR took 4.27s vs 4.27s on master (0% slower)
:book: Linting SourceKitten with this PR took 1.06s vs 1.03s on master (2% slower)
:book: Linting Sourcery with this PR took 8.43s vs 8.46s on master (0% faster)
:book: Linting Swift with this PR took 11.35s vs 11.48s on master (1% faster)
:book: Linting WordPress with this PR took 18.3s vs 18.56s on master (1% faster)
:book: This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/App/Networking/NetworkLogger.swift:13:5: warning: Inclusive Language Violation: Declaration init(whitelist:blacklist:) contains the term "whitelist" which is not considered inclusive. (inclusive_language)

Generated by :no_entry_sign: Danger

SwiftLintBot avatar Feb 16 '21 23:02 SwiftLintBot

What's the purpose of the parent directory configuration option? Note that SwiftLint already determines the root directory being linted, which might be want you want to access, but I'm not sure because I don't understand the purpose of the configuration option.

jpsim avatar Feb 25 '21 22:02 jpsim

What's the purpose of the parent directory configuration option? Note that SwiftLint already determines the root directory being linted, which might be want you want to access, but I'm not sure because I don't understand the purpose of the configuration option.

Yes, this is precisely what I wanted. The parent directory that SwiftLint is linting. Is there an example you can point me towards where I could access the said parent directory that SwiftLint already has access to?

You can see demonstrated in this test I wrote that the user would be able to filter out based on subdirectory.

    func testCustomParentDirectory() {
        XCTAssert(try validate(fileName: "Directory Name/SubdirectoryName/File.swift",
                               parentDirectory: "SubdirectoryName").isEmpty)
    }

timcmiller avatar Feb 25 '21 22:02 timcmiller

Is there an example you can point me towards where I could access the said parent directory that SwiftLint already has access to?

https://github.com/realm/SwiftLint/blob/8c29a8988888e2376d5c20c0ed61a1b885394d4a/Source/SwiftLintFramework/Models/Configuration.swift#L47-L50

I don't think we have any rules accessing this at the moment.

jpsim avatar Feb 25 '21 22:02 jpsim

Thanks @jpsim, I'll get the rule updated to look at rootDirectory and drop the parentDirectory configuration!

timcmiller avatar Feb 25 '21 22:02 timcmiller