Rouven Weßling

Results 34 comments of Rouven Weßling

@kuba-kubula @kylef Can you please have a look at this one & the other PRs I've opened? 🙏

Revisiting this PR, it doesn't seem like `gavel` is build with browsers in mind at all. Is there a reason to ship the UMD version at all? It might be...

Thanks for following up on this! I’ll be careful with my new powers. 😄 Not sure how it plays with the automation you’ve got set up but maybe try making...

Looking at https://nodejs.org/api/n-api.html#n_api_n_api_version_matrix, I think the minimum version supported has to be raised to 6.14. Maybe TravisCI should be adjusted to test on the minimum supported version of each LTS...

That's very interesting > Requiring minimum Node versions is simply too fragile Is that because npm doesn't bail out when the the minimum node version isn't met, instead just printing...

@Qix- Could you please have a look here? It's been open for 3 years today.

Have you considered using [rollup](https://rollupjs.org)? IMHO for libraries it's the better choice because of it's easier configuration and more compact result. I'd make a PR over the weekend to show...

Playing turned into getting it to work - check out #23.

@desmondmorris Could you merge this and tag a new minor? 🙏 Thank you!

@mrmartineau I haven't measured it but when bundling with webpack it should be a bit smaller because it's just one CJS module, not two. I'll actually remove the ESM version...