Tim Ruffing

I built this and ran the benchmarks on my machine (`12th Gen Intel(R) Core(TM) i7-1260P`) Signing became faster, but verification became slower. After looking at the bench_internal results, I figured...

utACK 57652a3e4e8c016701b2873f97f7bd5b4947e9fb Urghs, great catch. Now that I see this, I believe this is a larger (latent) problem. In most functions, entire `ge`s could alias, and I doubt the code...

> 2. should this be shipped with SP module or separately? only problem with separate release would be redundant APIs like `secp256k1_silentpayments_sender_create_outputs` and `secp256k1_silentpayments_sender_create_outputs_with_proof` for backward compatibility. @josibake Do you...

> > ``` > > 2. should this be shipped with SP module or separately? only problem with separate release would be redundant APIs like `secp256k1_silentpayments_sender_create_outputs` and `secp256k1_silentpayments_sender_create_outputs_with_proof` for backward...

Just some quick comments: > [x] remove the number of runs (`count`) in favor of simpler cleaner approach with just number of iterations (`iter`). I think there's a reason to...

It will be useful to split your changes into meaningful and separate commits, see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#committing-patches.

> > Concept NACK on removing any ability to observe variance in timing. The current min/avg/max are far from perfect, but they work fairly well in practice. Improving is welcome,...

> > The point is exactly having a simple way of verifying that there's indeed no interference. Getting rid of sources of variance is hard to get right, and it's...

> I haven't investigated this in detail but couldn't find any related issue: were there any efforts to use [nanobench.ankerl.com](https://nanobench.ankerl.com) like we do in Core instead? nanobench is a framework...

> > but adding C++ to the code base seems a bit overkill to me if if's "just" for the purpose of benchmarks > > The purpose would be to...