simple-binary-encoding icon indicating copy to clipboard operation
simple-binary-encoding copied to clipboard

Published 20 hours ago • verified publisher icon real-logic

[Rust] Generation: Avoid warnings

Open YuhanunCitgez opened this issue 9 months ago • 2 comments

This PR intends to avoid warnings that get generated because of some clippy flags.

We glob re-export the statics generated within the codecs, which causes issues due to duplicate naming.

In an ideal world, we would stop exporting the statics (or naming them uniquely), but for now I'd like to just avoid the warnings.

Additionally; get_bytes is unused and unusable outside of the generated code itself, rendering it useless for any real-world project.

YuhanunCitgez avatar May 07 '24 10:05 YuhanunCitgez

No clue why this failed 😓 Only Rust generation has changed. Is this an already failing test? @vyazelenko

YuhanunCitgez avatar May 13 '24 08:05 YuhanunCitgez

@YuhanunCitgez Try merging https://github.com/real-logic/simple-binary-encoding/commit/0053ff3e605efb2af3e79a2b20178a6e1f18255a commit into your branch.

vyazelenko avatar May 13 '24 09:05 vyazelenko

@vyazelenko Thanks, pushed.

Let me know if there's anything I need to do to get this into stable, tried to follow CONTRIBUTING as far as I could hahaha

YuhanunCitgez avatar May 14 '24 12:05 YuhanunCitgez

@vyazelenko shall we merge?

YuhanunCitgez avatar Jun 06 '24 14:06 YuhanunCitgez

Not sure how to push ahead here.

Pinging @vyazelenko and @mjpt777 :)

YuhanunCitgez avatar Jun 18 '24 11:06 YuhanunCitgez