aeron icon indicating copy to clipboard operation
aeron copied to clipboard

Add a string to Aeron connection

Open QIvan opened this issue 5 years ago • 2 comments

proposal: now every application has a uniq ID for each aeron connection. It would be convenient if application could add a string value to connection and that value would be visible in the Aeron stats. Like

Aeron.connect(new Aeron.Context().name("mySuperApp")); 

and in Aeron stats:

 29:    1,537,738,373,872 - client-heartbeat: 1 mySuperApp

Of course every app could publish the id to it's own monitoring system and bla-bla-bla. But I try to come up with a solution for aeron monitoring out the box and this value would be helpful.

QIvan avatar Oct 08 '20 18:10 QIvan

This can be done now. The application can Aeron.addCounter with the clientId value from Aeron.clientId and the string mySuperApp that it wants. No need to have Aeron do it.

tmontgomery avatar Oct 08 '20 18:10 tmontgomery

yes, application can do a lot of things. It can send a value to an elastic, can print in a file, you name it. I'm talking about what you've got out the box. Adding a counter is a kind of "advance" thing and I doubt everyone will do it by default and especially in the same format. So we cannot rely on stuff like that except it's done by the Aeron.connect() method

Add a name to connection is an intuitive thing which would everyone accept. It might be implemented with addCounter though but I think it shall be done on Aeron side.

QIvan avatar Oct 09 '20 12:10 QIvan