reagent icon indicating copy to clipboard operation
reagent copied to clipboard

Readme says npm i or add deps to .edn but (in my case at least) needed both

Open DeepReef11 opened this issue 2 years ago • 1 comments

Hi,

I've had troubles using Reagent because of this little or in the readme. I don't know if there are reasons to not install react and react-dom with npm but since it was saying or, I've skipped it and it caused errors. Maybe a little bit of clarification or replace 'or' by 'and' would prevent futur problems.

Readme.md:

And provide React using either npm (when using e.g. Shadow-cljs)

npm i react react-dom

or by adding Cljsjs React packages to your project:

[cljsjs/react "17.0.2-0"] [cljsjs/react-dom "17.0.2-0"]

DeepReef11 avatar Jun 07 '23 13:06 DeepReef11

It is "or" on purpose.

Shadow-cljs should work without cljsjs libs as it doesn't need even the extern files from those. Reagent test suite should be running Shadow-cljs build without cljsjs libs.

What kind of errors have you seen?

Deraen avatar Jun 09 '23 14:06 Deraen