sphinx_rtd_theme icon indicating copy to clipboard operation
sphinx_rtd_theme copied to clipboard

Test PR: Use dirhtml builder to see if #1407 works

Open benjaoming opened this issue 2 years ago • 3 comments

Testing #1407 with dirhtml builder enabled

benjaoming avatar Jan 11 '23 14:01 benjaoming

The test indicates that .html is trimmed. I'm not sure if the Canonical URL on PR builds is supposed to point to the stable branch, but it seems like a good idea to avoid search indexing PR builds.

benjaoming avatar Jan 11 '23 14:01 benjaoming

I am noticing that sphinx itself would have the same issue here: https://github.com/sphinx-doc/sphinx/blob/master/sphinx/themes/basic/layout.html#L132

Probably best to use a mixture of https://www.sphinx-doc.org/en/master/development/templating.html#file_suffix and https://www.sphinx-doc.org/en/master/development/templating.html#pagename

Blendify avatar Jan 17 '23 03:01 Blendify

@Blendify responded here: https://github.com/readthedocs/sphinx_rtd_theme/pull/1407#issuecomment-1385266816

benjaoming avatar Jan 17 '23 19:01 benjaoming