sphinx_rtd_theme icon indicating copy to clipboard operation
sphinx_rtd_theme copied to clipboard

Cleanup: Remove workaround/compatibility for old 0.3 version

Open Blendify opened this issue 3 years ago • 2 comments

This should now be safe to remove. I tested locally and sticky nav work both on and off.

I am not sure about the rtd side if this cases issues.

Blendify avatar Mar 30 '21 17:03 Blendify

Changes seem okay technically speaking, but it might be worth double checking on RTD usage first. In theory, old projects might use the common assets still, but we haven't updated the assets in the rtd.org repo in a while. Any changes here wouldn't be reflected in the common assets unless we decided to copy the built assets into rtd.org vendored assets again.

@davidfischer you helped split up common hosted assets back into per-build assets if I recall. Does this change seem relatively safe to you?

I did bump this out to 1.1 or later. I'd like to work towards a 1.0rc1 this week or next, and would like to limit the number of changes we're putting into that release.

agjohnson avatar Mar 31 '21 22:03 agjohnson

Marking this for 2.0 unless someone does a quick intervention :)

benjaoming avatar Aug 26 '22 19:08 benjaoming