sphinx_rtd_theme icon indicating copy to clipboard operation
sphinx_rtd_theme copied to clipboard

Cleanup: Remove wyrm specific icon sass

Open Blendify opened this issue 3 years ago • 7 comments

This removes wyrm specific icon sass and migrates fully to using font awesome.

There should be no difference to users

Blendify avatar Feb 27 '21 01:02 Blendify

This pull requests should actually be merged first, I based https://github.com/readthedocs/sphinx_rtd_theme/pull/1064 on the changes here.

Blendify avatar Mar 01 '21 16:03 Blendify

I guess the question is if we want to wait for a larger release or not

Blendify avatar Mar 01 '21 16:03 Blendify

Got it, I think we should include this together with the other in the same release

stsewd avatar Mar 01 '21 16:03 stsewd

@agjohnson is this change acceptable outside of the wyrm/bootstrap/sphinx2/html4/fontawesome5 changes?

Blendify avatar Mar 13 '21 04:03 Blendify

I'll target a 1.1 release for now, however I think this probably makes sense in a 2.0 release with a few other backwards incompatible changes before a 3.0 or greater bootstrap release.

agjohnson avatar Mar 17 '21 21:03 agjohnson

@agjohnson can this go into 1.1?

Blendify avatar Sep 29 '21 15:09 Blendify

Great update, should be merged quickly once we start working on 2.0. We could write alias css classes for .icon-* for backwards compatibility and add a deprecation note in the changelog.

benjaoming avatar Aug 27 '22 19:08 benjaoming