sphinx-autoapi icon indicating copy to clipboard operation
sphinx-autoapi copied to clipboard

Mark tests that use the network

Open QuLogic opened this issue 1 year ago • 2 comments

These two tests uses intersphinx, and the marker allows skipping them if there is no network available.

QuLogic avatar Jul 08 '24 05:07 QuLogic

Thanks for making this change. Why is this needed?

AWhetter avatar Jul 20 '24 17:07 AWhetter

This is useful for downstream packaging; in such cases builds aren't allowed to access the Internet at large, and instead of skipping all tests, it is useful to skip only the ones that require networking. I don't know that network is a standard name anywhere, but at least it's the one I suggest when making PRs like this.

QuLogic avatar Aug 18 '24 23:08 QuLogic

To get the GitHub Actions to pass...

echo "Mark pytests that use the network" > docs/changes/462.misc.rst
git add docs/changes/462.misc.rst
git commit -m"git add docs/changes/462.misc.rst"
git push

cclauss avatar Oct 12 '24 03:10 cclauss

Thanks for the ping; I've fixed that, and the conflict.

QuLogic avatar Oct 12 '24 04:10 QuLogic

Thanks for fixing this yourself and keep the pull request up to date. I've merged this as 0d5f21b8650d6202208f0cf00f498a16a1e32379

AWhetter avatar Oct 25 '24 23:10 AWhetter