readthedocs.org icon indicating copy to clipboard operation
readthedocs.org copied to clipboard

Project tags can not be updated using the API

Open nijel opened this issue 4 years ago • 4 comments

Details

  • Read the Docs project URL: https://readthedocs.org/projects/weblate/

Expected Result

The projects API does include project tags, but it's not possible to update it or set when creating new projects.

Actual Result

When including tags in the request, it gets silently ignored.

Another source of confusion might be that ProjectCreateSerializer and ProjectCreateSerializer are different - is there any reason to allow less fields in project creating than later in updating it?

nijel avatar Aug 03 '20 07:08 nijel

Another source of confusion might be that ProjectCreateSerializer and ProjectCreateSerializer are different - is there any reason to allow less fields in project creating than later in updating it

I think that was done to mimic the import page, but if we don't have a strong reason, I think it makes sense to allow all the fields

stsewd avatar Aug 03 '20 15:08 stsewd

I think it makes sense to allow all the fields

I'm fine adding support to change most (or all) the fields at this point.

humitos avatar Mar 15 '21 12:03 humitos

@humitos Is this issue still open?

SyedMa3 avatar Aug 07 '22 08:08 SyedMa3

@SyedMa3 yes

humitos avatar Aug 08 '22 09:08 humitos

Fixed in https://github.com/readthedocs/readthedocs.org/pull/9513 - thanks to @SyedMa3 for this contribution :+1:

benjaoming avatar Nov 01 '22 10:11 benjaoming