Readrops icon indicating copy to clipboard operation
Readrops copied to clipboard

Expecting END_OBJECT issue

Open mbnoimi opened this issue 2 years ago • 4 comments

First of all I'd like to thank you a lot for the greate project.

Whenever I try to connect Readrops with my FreshRSS service I get this error message:

Expected END_OBJECT but was NAME at path $.item[0].alternate[0].href

Is there anything wrong with my service configuration or what?

  • https://github.com/FreshRSS/FreshRSS/commit/e27eb1ca9198119ea1b0bd79be5f1aead45d615a
  • Readrops: 1.3.1 (14)
  • My service located in: https://top.mydomain/p/
  • FreshRss Android Client works fine.

image

mbnoimi avatar Aug 17 '22 08:08 mbnoimi

I'm getting the same error, but for context I also just changed my Fresh RSS container in a few ways

  • Switched from linuxserver.io's FreshRSS Docker container to the official
  • Switched to the FreshRSS edge branch from latest
  • Switched from HTTPS connection to the container to HTTP via reverse proxy from external HTTPS request.

InterferencePattern avatar Aug 19 '22 23:08 InterferencePattern

It looks like a bug in:

https://github.com/readrops/Readrops/blob/8a5fae5411420a135162143d7e279157dc17555c/api/src/main/java/com/readrops/api/services/freshrss/adapters/FreshRSSItemsAdapter.kt#L85-L102

the response might contain:

	"alternate": [
		[
			"href": "https://example.net",
			"type": "text/html"
		]
	]

The line "type": "text/html" was not always provided before.

In any case, additional key-values should not break the parsing.

Alkarex avatar Aug 31 '22 10:08 Alkarex

Patch suggestion (not tested - no compile environment set up) https://github.com/readrops/Readrops/pull/163

Alkarex avatar Aug 31 '22 10:08 Alkarex

Workaround https://github.com/FreshRSS/FreshRSS/pull/4568 while waiting for above Readrops fix to be tested and merged.

Alkarex avatar Aug 31 '22 11:08 Alkarex