swift-toolkit icon indicating copy to clipboard operation
swift-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon readium

add `findElementLocator`

Open erikolsson opened this issue 2 years ago • 3 comments

Hi!

Here's a rough implementation of what findElementLocator(at point: CGPoint) could look like. Not sure if there's a cleaner way to do the coordinate transformation in EPUBSpreadView.swift?

erikolsson avatar Feb 15 '23 11:02 erikolsson

Hi @erikolsson, are you still interested in getting this PR merged?

mickael-menu avatar Apr 03 '23 09:04 mickael-menu

Hi @mickael-menu! I'm terribly sorry, I took another approach (wrote my own renderer in UIKit) and ran out of time! I will probably not have time to do these changes in the near future, but if someone else has the time, please feel free to make whatever changes you see fit to this PR!

erikolsson avatar Apr 03 '23 12:04 erikolsson

Alright, thanks for the heads-up. I might take over the PR once I have some leeway.

mickael-menu avatar Apr 03 '23 12:04 mickael-menu