URI is expected to be global in views/internal_links_support.js

[bradleygore]

This issue is a Bug

Expected Behaviour

Expected that URI(..) object being used would be injected w/ RequireJS instead of expected to be global.

Observed behaviour

The URI object is used inside views/internal_links_support.js but is not in the injected params: Usage: https://github.com/readium/readium-shared-js/blob/aa0d5722818e21b7fd0c16f21f58f09976215a39/js/views/internal_links_support.js#L157 Module Params: https://github.com/readium/readium-shared-js/blob/aa0d5722818e21b7fd0c16f21f58f09976215a39/js/views/internal_links_support.js#L25

[danielweck]

Thanks! There is already a TODO in the "globals setup" code: https://github.com/readium/readium-shared-js/blob/develop/js/globalsSetup.js#L34

For future reference:

The RequireJS alias for dependency injection is "URIjs": https://github.com/readium/readium-shared-js/blob/develop/build-config/RequireJS_config_common.js#L38

The NodeJS module is "urijs": https://github.com/readium/readium-shared-js/blob/develop/package.cson#L123