readium-shared-js icon indicating copy to clipboard operation
readium-shared-js copied to clipboard

Rdh compute rectangles for svg

Open kimtuck opened this issue 9 years ago • 4 comments

This pull request is Finalized

Related issue(s) and/or pull request(s)

See #340

Test cases, sample files

Additional information

In some cases, the book may have an image which is surrounded by a svg tag like this: <svg:svg ....><svg:image ....></svg:image></svg:svg> In this case, the containing svg must be used to find the client rectangles. Some epub books have a cover page which is structured like this; with no other content. Without this change, it appears to readium that there is no visible content on the page, because it can't find the first visible cfi.

kimtuck avatar Nov 22 '16 16:11 kimtuck

Looks good to me. Could you please update the readium-cfi-js repository (as per the latest commit in the develop branch), so that the conflict is resolved? Thanks!

danielweck avatar Nov 22 '16 16:11 danielweck

Let's create / find an EPUB sample to reproduce the associated issue, and let's merge this PR.

  • @rkwright

danielweck avatar Jan 10 '17 17:01 danielweck

I'm ok with merging this, not sure about the submodule ref update though.

jccr avatar Jul 10 '17 23:07 jccr

The cfi_navigation_logic.js file is now in conflict, so we might need to cherry-pick the code change manually (it is quite straight-forward). If so, let's remember to cross-reference this PR and credit @kimtuck for the fix.

danielweck avatar Jul 13 '17 20:07 danielweck