readium-shared-js icon indicating copy to clipboard operation
readium-shared-js copied to clipboard

Highlights on Internet Explorer 11

Open tmoreno opened this issue 9 years ago • 2 comments

This issue is a Bug

Expected Behaviour

I would like to remove highlights when I click on them

Observed behaviour

I can remove highlights when the highlights are not on the first chapter page

Steps to reproduce

  1. Open this epub with Internet Explorer 11: http://readium.github.io/readium-js-viewer/?epub=http%3A%2F%2Freadium.github.io%2Freadium-js-viewer%2Fepub_content%2Femerald-city-oz&
  2. Go to chapter 1
  3. Change page.
  4. Select some text.
  5. Click on highlight text button
  6. Click on the new highlight for remove it

More Info

I think the problem is in boundHighlightCallback function (group.js file) when get pageX and pageY

Product

  • Readium cloud reader app

tmoreno avatar Sep 27 '16 14:09 tmoreno

Hi,

Any good news?

tmoreno avatar Jun 19 '17 06:06 tmoreno

Hello, I have just noticed that your cloud reader link ( http://readium.github.io/readium-js-viewer/ ) references an older version (2.23.0-alpha: Tue, 02 Feb 2016 15:30:31 GMT).

The official web reader instances are actually uploaded at:

https://readium.firebaseapp.com (with a backup / fallback mirror at https://readium.surge.sh ) (from the develop branch, automatically deployed via the TravisCI continuous integration service) 2.28.0-alpha: Fri, 08 Sep 2017 09:12:34 GMT

https://readium-master.surge.sh (from the master branch, manually deployed at each release) 2.27.0: Mon, 12 Jun 2017 08:48:20 GMT

Now, the "highlight" plugin has recently been deactivated in the latest default builds (you can still activate it yourself, but you have to rebuild the app and deploy it on your sever). So, here is a correct cloud reader link using the latest master release (which still had the "highlight" plugin):

https://readium-master.surge.sh/?epub=https%3A%2F%2Freadium.github.io%2Freadium-js-viewer%2Fepub_content%2Femerald-city-oz&goto=%7B%22idref%22%3A%22main1%22%2C%22elementCfi%22%3A%22%2F4%2F2%2F2%5Bchapter_10198%5D%2F2%2F2%2F2%2F1%3A0%22%7D

danielweck avatar Sep 10 '17 21:09 danielweck