readium-shared-js icon indicating copy to clipboard operation
readium-shared-js copied to clipboard

Missing JS files in payload causes cache miss on each page load

Open rkwright opened this issue 9 years ago • 1 comments

This issue is a Other

It is a bad EPUB, so this may not be a bug.

Reported by Michelle Sintov: "We strip 22 js files out of our PubCoder epub files during post-processing but we don't remove the now-unnecessary JS script tags from each xhtml file that refer to those removed files. This results in a cache miss for each file not only on book load but also on each page load. You can see this behavior if you take the Space Aliens epub and delete the following folder, which contains 22 js files: OEBPS/js/"

Related issue(s) and/or pull request(s)

None known

Expected Behaviour

Should somehow not cause problems on each page load?

Observed behaviour

Instead, Readium does...

Steps to reproduce

  1. Load test file
  2. Page through it
  3. Observe

Test file(s)

Space-Alien-No-JS.epub

Product

SDKLauncher-iOS

Additional information

None

rkwright avatar Aug 18 '16 19:08 rkwright

In fact, there are a lot of errors in the file (icons present that aren't in the OPF, etc.). Not sure this is worth even looking into. FingerPrintPlayer needs to run their files through EPUBChecker before release.

rkwright avatar Aug 18 '16 19:08 rkwright