readium-shared-js icon indicating copy to clipboard operation
readium-shared-js copied to clipboard

Published 20 hours ago • verified publisher icon readium

fix IE's script70 error

Open dariocravero opened this issue 8 years ago • 3 comments

Whenever we scroll Readium tries to find the next visible media overlay element to play. The problem arises when the user changed the page and had scrolled before. Some funny combination of things triggers the scroll handler to run again and because it has a stale reference of the iframe's document IE gives out with the script70 error message. This commit unbinds the scroll handler before that can even happen, i.e., when we are about to open a new page and rebinds it once its done.

May fix #162.

dariocravero avatar Oct 01 '15 04:10 dariocravero

@nbeach, this might sort out https://github.com/readium/readium-js-viewer/issues/295, would you mind giving it a go?

dariocravero avatar Oct 01 '15 04:10 dariocravero

@dariocravero Thanks for this. I can give it a go.

jccr avatar Oct 05 '15 20:10 jccr

Good stuff, let me know how it goes.

On Mon, Oct 5, 2015 at 5:03 PM Juan Corona [email protected] wrote:

@dariocravero https://github.com/dariocravero Thanks for this. I can give it a go.

— Reply to this email directly or view it on GitHub https://github.com/readium/readium-shared-js/pull/222#issuecomment-145651984 .

dariocravero avatar Oct 07 '15 12:10 dariocravero