readium-sdk

readium-sdk copied to clipboard

https://github.com/readium/readium-sdk/blob/develop/ePub3/ePub/package.cpp#L814 ``` auto found = _xmlIDLookup.find(ident); if ( found == _xmlIDLookup.end() ) { HandleError(EPUBError::OPFInvalidRefinementTarget, _Str("#", ident, " does not reference an item in this document")); continue; } ``` The debugger...

danielweck

"refines" OPF metadata fails when includes not only fragment, but also filepath

1

Test EPUB: https://code.google.com/p/epub-samples/downloads/detail?name=widget-figure-gallery-20121022.epub OPF: ``` ``` Resulting error with SDKLauncher-OSX: ``` #text.xhtml#moon-text is not a valid IRI: Unspecified EPUB specification error #text.xhtml#moon-figures is not a valid IRI: Unspecified EPUB specification...

danielweck

EPUB3 bindings uses default "epub3://" URI scheme, does not correctly fetch XHTML handler from EPUB archive?

1

See original discussion: https://groups.google.com/d/msg/readium-dev/1RUBYB9jHxU/QgWXkwmq45MJ Test EPUB: https://code.google.com/p/epub-samples/downloads/detail?name=widget-figure-gallery-20121022.epub ``` ``` Code references: https://github.com/readium/readium-sdk/blob/develop/ePub3/ePub/object_preprocessor.cpp https://github.com/readium/readium-sdk/blob/develop/ePub3/ePub/content_handler.h The epub3:// URI scheme comes from here: https://github.com/readium/readium-sdk/blob/develop/ePub3/utilities/iri.cpp#L34 ...and set to the iframe here: https://github.com/readium/readium-sdk/blob/develop/ePub3/ePub/object_preprocessor.cpp#L160 **This appears...

danielweck

Mario Couture / Gregory Muirhead from Kivuto recently suggested the following (please share your thoughts here in the issue tracker): " In RDPackageResourceConnection the class method to set the RDPackageResourceServer...

danielweck

https://github.com/readium/readium-sdk/blob/develop/ePub3/ePub/package.cpp#L1307 https://github.com/readium/readium-sdk/blob/develop/ePub3/ePub/package.cpp#L1355 See original issue for further details: https://github.com/readium/SDKLauncher-Android/issues/21

danielweck

See: https://github.com/readium/SDKLauncher-Windows/issues/15#issuecomment-66353984 Is that another case of ASYNC code removal? Should we just remove this unused code, given that the "readium signature" method is now used to track XML node...

danielweck

Error handling: should discriminate EPUB version 2 / 3 ?

2

The hard-coded error types do not seem bound to the version of the EPUB that is being parsed, which results in EPUB2 files being incorrect reported as invalid when missing...

danielweck

Remove Async code

4

See: https://groups.google.com/forum/#!topic/readium-dev/hVsULfGCcAk

danielweck

Jenkins continuous integration / automated builds (broken links)

2

The links are broken in the readium-sdk README: https://github.com/readium/readium-sdk/blob/develop/Readme.markdown (datalogics server)

danielweck

Remove: https://github.com/readium/readium-sdk/blob/develop/ePub3/ePub/cfi-resolver.js Instead, this repository is used: https://github.com/readium/readium-cfi-js/ ...which gets built into this single-file library: https://github.com/readium/readium-shared-js/blob/develop/lib/epub_cfi.js

danielweck