readium-js-viewer icon indicating copy to clipboard operation
readium-js-viewer copied to clipboard

Fix #49: Add additional Japanese localization strings provided by toshiakikoike

Open kden opened this issue 8 years ago • 2 comments

This pull request is Finalized

Related issue(s) and/or pull request(s)

#49

Test cases, sample files

My Japanese is rusty, so I validated each new string by looking it up in Google translate and making sure that it was at least a reasonable approximation of the English version (and not, for example, Spam.)

I had to test in Firefox because for some reason the navigator.userLanguage was undefined and navigator.language was en_US in Chrome (Ubuntu 14.04), even though I set my browser preferences to Japanese. In Firefox, I could see and confirm some of the new strings under the Settings->Style menu and they looked fine.

Additional information

kden avatar Jun 21 '16 20:06 kden

Hello, thank you very much for your contribution. Do you have time to compare with the latest i18n messages in the develop branch? I think there are 2 or 3 new labels to translate. We will review the pending language contributions to merge them as soon as possible. Kind regards, Daniel

danielweck avatar Dec 22 '16 17:12 danielweck

Is there still interest in having this done, or should I close it out?

kden avatar Feb 16 '22 22:02 kden