readium-js-viewer
readium-js-viewer copied to clipboard
readium
Feature/non linear spine items
User interface for https://github.com/readium/readium-shared-js/pull/211
Fixes: https://github.com/readium/readium-js-viewer/issues/188
Aside from the conflicts noted above and in the related PR 211, is there more work to be done here?
@rkwright yes, I need to test Media Overlays (make sure the boundaries of the ancillary document are not crossed when audio playback reaches the end of the spine item), and I need to check the general behaviour in the scroll view mode(s).
Defer out of 0.22 because there is more testing and some minor modifications still needed.
Not sure why I was not seeing this correctly yesterday but I do see now the |<< at the top left hand side of the content view the small button labelled ("Return to Primary Reading Flow [0]") when I hover over a non-linear document (right above where the Previous Page button would be when there are more than one page to move back from.
Also the shortcut key 0 also seems to work as expected and from my point of view this looks great.
I think the shortcut "0" is fine, I think the icon image is fine as well (i.e.: play on the REW and REW to Beginning from the old tape deck days which I think makes a lot of sense)
Is there anything else we need to decide before this gets merged into Readium main developers branch?
I think this is a UI that is a bit easter-eggy in that you need to hover over the right spot to see the UI.
Ric
From: AnFengDe [email protected] Reply-To: readium/readium-js-viewer <reply+002e2bc83fb8e48d8e70d6002e6bc39e6a50139b47443cc692cf0000000113a793449 [email protected]> Date: Wednesday, July 20, 2016 at 2:30 PM To: readium/readium-js-viewer [email protected] Cc: Ric Wright [email protected], Mention [email protected] Subject: Re: [readium/readium-js-viewer] Feature/non linear spine items (#402)
Not sure why I was not seeing this correctly yesterday but I do see now the |<< at the top left hand side of the content view the small button labelled ("Return to Primary Reading Flow [0]") when I hover over a non-linear document (right above where the Previous Page button would be when there are more than one page to move back from.
Also the shortcut key 0 also seems to work as expected and from my point of view this looks great.
I think the shortcut "0" is fine, I think the icon image is fine as well (i.e.: play on the REW and REW to Beginning from the old tape deck days which I think makes a lot of sense)
Is there anything else we need to decide before this gets merged into Readium main developers branch?
You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/readium/readium-js-viewer/pull/402#issuecomment-23405613 9> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AC4ryJPscnp5Nf9ykB7_Fji7G 51xbPiEks5qXndEgaJpZM4F_g6w> .
I see, and I guess the same goes for the bottom left corner where the |< "Go Back in Navigation History [9]" pops up when you hover over that area if applicable.
If that the case then maybe would we want to make those new buttons show up all the time when you are on a non-linear page to show the user that there is something special here and it helps them get back to where they were?
I think everyone understands what the top button in the upper left corner will do right? This will always bring you back no matter how many pages you go down on a non-linear document or even if one non-linear document references another non-linear document and the user then follows that and goes multiple pages in that document that pressing this top left button "Return to Primary Reading Flow [0]" that the user will be brought straight back to where they left off in the original book before they explored the non-linear content. (I assume everyone agrees this is what this button does)
I guess my other question is how that 2nd button in the bottom left corner "Go Back in Navigation History [9]" behaves since I am trying to understand what it does especially when there are multiple pages on a non-linear page and maybe what the behavior is when one non-linear page links to another non-linear page which may have multiple pages on it as well. Either this button is not doing what it was meant to do or I am really not understanding what it should do.
I thought this would bring you back page by page, and document by document until you get ultimately back to the main document before you started exploring the non-linear spine item. What is a little confusing is that the link Daniel gave http://readium-diagram.surge.sh/?epub=nonLinear starts at the nonLinear page so this button doesn't appear initially and then clicking on the embedded link to the << (8) linear (primary) will cause this button to start showing up in the bottom left corner which when pressed brings you back to the non-linear page. So what was messing me up is I started at the non-linear page, then pressed the link to << (8) linear (primary) then pressed the link (9) non-linear (ancillary) > at which point finally the "Button: Return to Primary reading flow [0]" appears but the "Button: Go Back in Navigational History [9] can be pressed twice, once to go back to the main document and again to bring you back to the non-linear page since this was the first page you were on since the link itself was to this non-linear page originally. I guess that all makes sense but just making sure this is what everyone expects to happen.
We can discuss this with a UI/UX employee if you would like but I am trying to understand what we want/need here.
Thanks Charles.